From: Junio C Hamano <gitster@pobox.com>
To: "John Cai via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Cai <johncai86@gmail.com>
Subject: Re: [PATCH v4] receive-pack.c: consolidate find header logic
Date: Wed, 05 Jan 2022 12:10:34 -0800 [thread overview]
Message-ID: <xmqqczl6hrk5.fsf@gitster.g> (raw)
In-Reply-To: <pull.1125.v4.git.git.1641396098056.gitgitgadget@gmail.com> (John Cai via GitGitGadget's message of "Wed, 05 Jan 2022 15:21:37 +0000")
"John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Changes since v4:
>
> * added NEEDSWORK block detailing what needs to be done to clean up
> find_header_mem
> ...
> - while (line) {
> ++ /*
> ++ * NEEDSWORK: Between line[0] and msg[len], there may not be a LF nor NUL
> ++ * at all, and strchrnul() will scan beyond the range we were given
> ++ * Make this operation safer and abide by the contract to only read up to len.
> ++ */
This sounds unnecessarily alarming. Can't we also explain that the
current callers are safe?
next prev parent reply other threads:[~2022-01-05 20:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 18:26 [PATCH 0/2] Consolidate find_header logic into one function John Cai via GitGitGadget
2021-12-27 18:26 ` [PATCH 1/2] receive-pack.c: consolidate find header logic John Cai via GitGitGadget
2021-12-27 22:33 ` Junio C Hamano
2021-12-27 18:26 ` [PATCH 2/2] commit.c: rename find_commit_header to find_header John Cai via GitGitGadget
2021-12-29 6:19 ` [PATCH v2] receive-pack.c: consolidate find header logic John Cai via GitGitGadget
2021-12-30 23:01 ` Junio C Hamano
2021-12-31 6:17 ` [PATCH v3] " John Cai via GitGitGadget
2022-01-04 1:56 ` Junio C Hamano
2022-01-04 15:12 ` John Cai
2022-01-05 15:21 ` [PATCH v4] " John Cai via GitGitGadget
2022-01-05 20:10 ` Junio C Hamano [this message]
2022-01-06 0:51 ` [PATCH v5] " John Cai via GitGitGadget
2022-01-06 19:40 ` Junio C Hamano
2022-01-06 20:07 ` [PATCH v6] " John Cai via GitGitGadget
2022-01-08 4:54 ` John Cai
2022-01-08 7:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczl6hrk5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).