git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>,
	Glen Choo <chooglen@google.com>
Subject: Re: ab/config-based-hooks-2
Date: Tue, 18 Jan 2022 12:26:10 -0800	[thread overview]
Message-ID: <xmqqczkossd9.fsf@gitster.g> (raw)
In-Reply-To: <220118.86a6ftowx3.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 18 Jan 2022 16:59:04 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Fri, Jan 14 2022, Junio C Hamano wrote:
>
>> * ab/config-based-hooks-2 (2022-01-07) 17 commits
>>  - run-command: remove old run_hook_{le,ve}() hook API
>>  - receive-pack: convert push-to-checkout hook to hook.h
>>  - read-cache: convert post-index-change to use hook.h
>>  - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
>>  - git-p4: use 'git hook' to run hooks
>>  - send-email: use 'git hook run' for 'sendemail-validate'
>>  - git hook run: add an --ignore-missing flag
>>  - hooks: convert worktree 'post-checkout' hook to hook library
>>  - hooks: convert non-worktree 'post-checkout' hook to hook library
>>  - merge: convert post-merge to use hook.h
>>  - am: convert applypatch-msg to use hook.h
>>  - rebase: convert pre-rebase to use hook.h
>>  - hook API: add a run_hooks_l() wrapper
>>  - am: convert {pre,post}-applypatch to use hook.h
>>  - gc: use hook library for pre-auto-gc hook
>>  - hook API: add a run_hooks() wrapper
>>  - hook: add 'run' subcommand
>>
>>  More "config-based hooks".
>>
>>  Will merge to 'next', with minor nits?
>>  source: <cover-v6-00.17-00000000000-20211222T035755Z-avarab@gmail.com>
>
> I'd really like that, if you're OK with it.


Obviously I am not ready to say I am OK (or not OK for that matter),
and that is why I was soliciting comments by the reviewers whose
comments were ignored.

And knowing how proliferate you can be when you want to, adjusting
patches for reviews you received and testing the result thoroughly
would be much better use of time (include the time already spent by
reviewers to comment on the previous iteration), no?

  parent reply	other threads:[~2022-01-18 20:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-15  4:37 What's cooking in git.git (Jan 2022, #04; Fri, 14) Junio C Hamano
2022-01-16  4:25 ` Elijah Newren
2022-01-17 18:30   ` Junio C Hamano
2022-01-18 15:56 ` ab/grep-patterntype (was: What's cooking in git.git (Jan 2022, #04; Fri, 14)) Ævar Arnfjörð Bjarmason
2022-01-18 15:59 ` ab/config-based-hooks-2 " Ævar Arnfjörð Bjarmason
2022-01-18 19:49   ` Glen Choo
2022-01-19 21:32     ` Emily Shaffer
2022-01-18 20:26   ` Junio C Hamano [this message]
2022-01-18 16:08 ` ds/sparse-checkout-requires-per-worktree-config (was " Derrick Stolee
2022-01-18 20:27   ` Junio C Hamano
2022-01-19  0:38 ` ar/submodule-update " Glen Choo
2022-01-19  0:53   ` Junio C Hamano
2022-01-19 20:06 ` What's cooking in git.git (Jan 2022, #04; Fri, 14) Phillip Wood
  -- strict thread matches above, loose matches on Subject: below --
2021-10-30  0:17 What's cooking in git.git (Oct 2021, #07; Fri, 29) Junio C Hamano
2021-11-01 19:26 ` ab/config-based-hooks-2 (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 20:17   ` ab/config-based-hooks-2 Junio C Hamano
2021-10-19  6:48 What's cooking in git.git (Oct 2021, #05; Mon, 18) Junio C Hamano
2021-10-20 11:37 ` ab/config-based-hooks-2 Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqczkossd9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=chooglen@google.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).