From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=0.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id D3B191F852 for ; Mon, 14 Feb 2022 17:22:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357008AbiBNRW7 (ORCPT ); Mon, 14 Feb 2022 12:22:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240202AbiBNRW6 (ORCPT ); Mon, 14 Feb 2022 12:22:58 -0500 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E3AA652EF for ; Mon, 14 Feb 2022 09:22:50 -0800 (PST) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id D285C180D7E; Mon, 14 Feb 2022 12:22:49 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=pOsWr03V8RiF D8bRTHHLr0E37mUnVGJ/PBwvFj9wpIQ=; b=LaNJWxgknbrB2a/c2yqf1FPFAKrJ MVus2jDt03EtApRMzKxCRoN8nMYAaJooIV6T+wDgxZYpyo13nNDfx/ExVNw0X4oC xK8yFT+e2F7bPJFnthSKy5FBzhgrWXTdVjqJKjwNElP8taTiIUhPA7GogdzCQZss q91B6ZYErxyNrI0= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id CA0AF180D7D; Mon, 14 Feb 2022 12:22:49 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.185.212.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 36A3B180D7C; Mon, 14 Feb 2022 12:22:47 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?Q?Ren=C3=A9?= Scharfe Cc: Johannes Schindelin , Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Taylor Blau , Derrick Stolee , Elijah Newren Subject: Re: [PATCH v2 1/6] archive: optionally add "virtual" files References: <49ff3c1f2b32b16df2b4216aa016d715b6de46bc.1644187146.git.gitgitgadget@gmail.com> <6f3d288a-8c2f-0d63-ea17-f6c038a9fa3e@web.de> <2d4358db-fc6e-dc89-e647-b1b810817873@web.de> Date: Mon, 14 Feb 2022 09:22:46 -0800 In-Reply-To: <2d4358db-fc6e-dc89-e647-b1b810817873@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Sun, 13 Feb 2022 10:02:07 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: BA67468E-8DBA-11EC-A2C8-C85A9F429DF0-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ren=C3=A9 Scharfe writes: > Am 13.02.22 um 07:25 schrieb Junio C Hamano: >> >> So we do need some extra "manifest" to declare what's untracked etc., >> if we allow --add-file etc. to munge the tree when creating a tarball >> out of it. > > Right, or get that information from the order of files in the archive, > by having tracked files come first, then the signature file with a > certain name and then untracked files. That sounds like a workable approach, modulo that the details of the "signature file with a certain name" part needs to be worked out. We should make sure that we clearly document that "--add-file=3D" and friends add their material after the contents that come from the tree-ish, and make sure that the program does so and will stay doing so. Otherwise users cannot easily create an archive that follows the above rule. Thanks.