git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Strawbridge <michael.strawbridge@amd.com>
Cc: "Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Emily Shaffer" <nasamuffin@google.com>,
	"Doug Anderson" <dianders@chromium.org>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [REGRESSION] uninitialized value $address in git send-email
Date: Wed, 20 Sep 2023 08:36:22 -0700	[thread overview]
Message-ID: <xmqqcyycc0w9.fsf@gitster.g> (raw)
In-Reply-To: <118975ef-c07f-c397-5288-7698e60516a7@amd.com> (Michael Strawbridge's message of "Tue, 19 Sep 2023 10:37:36 -0400")

Michael Strawbridge <michael.strawbridge@amd.com> writes:

> Whoops, somehow I missed the other responses on this thread until I
> looked on the web archive version of this mailing list.  I see that a
> solution to "Use of uninitialized value $address" has already been proposed.
>
> I suppose I may have mistook what issue was being reported.  I had
> originally understood the problem to be that hook related logic was
> failing with correct email addresses, but it seems rather that we are
> trying to fix an error that occurs when an email address that fails
> extract_valid_address_or_die() is given.  Feel free to ignore my last
> email if that is all we are trying to solve.

I just had an impression that the original was complaining about the
command failing, and the patches addressed a side issue that the
error message that is given when the command fails uses an undefined
value.  The report was not quite clear what Bagas considerd a
regression (e.g. did the command allow an invalid address like <pi@pi>
but now it complains?), though.

      parent reply	other threads:[~2023-09-20 15:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 12:56 [REGRESSION] uninitialized value $address in git send-email Bagas Sanjaya
2023-09-18 16:35 ` [PATCH] git-send-email.perl: avoid printing undef when validating addresses Taylor Blau
2023-09-18 19:04   ` Junio C Hamano
2023-09-18 21:20   ` Jeff King
2023-09-18 20:26 ` [REGRESSION] uninitialized value $address in git send-email Michael Strawbridge
2023-09-19  4:44   ` Bagas Sanjaya
2023-09-19 14:04     ` Michael Strawbridge
2023-09-19 14:37       ` Michael Strawbridge
2023-09-20 11:00         ` Bagas Sanjaya
2023-09-20 13:14           ` Michael Strawbridge
2023-09-20 15:43           ` Junio C Hamano
2023-09-21  7:51             ` Bagas Sanjaya
2023-09-21 20:42               ` Junio C Hamano
2023-09-22  7:39                 ` Bagas Sanjaya
2023-09-20 15:36         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcyycc0w9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=dianders@chromium.org \
    --cc=git@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=michael.strawbridge@amd.com \
    --cc=nasamuffin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).