From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7624C1F406 for ; Sat, 9 Dec 2023 18:59:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=Y/JzVGfq; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5C9B51C2090E for ; Sat, 9 Dec 2023 18:59:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0BF1D1A284; Sat, 9 Dec 2023 18:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="Y/JzVGfq" Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4034412E for ; Sat, 9 Dec 2023 10:59:06 -0800 (PST) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 7F780361C6; Sat, 9 Dec 2023 13:59:05 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=+5ylSrX9kmiTl5LSS+QYoVieeY439SsYk7glhO 2Fl3g=; b=Y/JzVGfqkX2QgMCYHtDorqAwX5V4/TzwyD1o+Amn4KqXPgljD/UdJ/ kBFjt2yiCwWVz46lObxLz+tIjNkCHUKt2j8xXfnfQWuXHwtquBcOWcVCMvgWJtO4 theDWGl/xCVELiG62XM3mKW8ZUsdzU6CjOPkS5oHb7dB466WY5Cyw= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 767DA361C5; Sat, 9 Dec 2023 13:59:05 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.103.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 1E0D1361C3; Sat, 9 Dec 2023 13:59:02 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jiang Xin Cc: git@vger.kernel.org, Jiang Xin , Mathias Lafeldt , Christian Couder Subject: Re: New attempt to export test-lib from Git, maybe Sharness2? In-Reply-To: <802ca62b9d9672e9553ab064452d46e0d72dfc76.1702116416.git.zhiyou.jx@alibaba-inc.com> (Jiang Xin's message of "Sat, 9 Dec 2023 21:35:39 +0800") References: <802ca62b9d9672e9553ab064452d46e0d72dfc76.1702116416.git.zhiyou.jx@alibaba-inc.com> Date: Sat, 09 Dec 2023 10:59:00 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 0462F3B8-96C5-11EE-A35E-F515D2CDFF5E-77302942!pb-smtp20.pobox.com Jiang Xin writes: > It's not easy to upgrade sharness to the latest test framework of Git. So? > So I decide to start a new project. The new project is named test-lib, > see: > > * https://github.com/jiangxin/test-lib > > Some of my projects have upgraded the test framework from sharkness to > test-lib: > > * git-po-helper: https://github.com/git-l10n/git-po-helper/tree/main/test > * git-repo-go: https://github.com/alibaba/git-repo-go/tree/master/test > > I wonder if we can start Sharness2 based on this solution. See the > README of the test-lib project for details: Is it a viable option to stick to the name "test-lib" (or possibly, "git-test-lib" to make it more prominent to say where it came from)? If you do not plan to coordinate with those who work on (the remnant of) the original sharness based on an ancient version of our test framework, and do not plan to actively transition its users to your version, it is less confusing if you named yours differently, as it avoids hinting that your version is a successor of theirs. I am not sure if reusing the history of our project verbatim using filter-repo is really a good way to help those who are interested in the test framework, by the way. We make changes for our own purpose and as a part of such an effort we may touch the test framework to make it easier to test the changes we made, e.g., https://github.com/jiangxin/test-lib/commit/0d5db66ef2b9d8ed5bcee9a0167672dc88b1b026 and unedited filter-repo result will describe such a commit primarily to explain why the changes in the commit was made on Git side. Most of the changes described in the resulting commit message are discarded by filter-repo and the resulting history becomes hard to follow.