From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2015, #05; Tue, 15)
Date: Tue, 15 Dec 2015 15:36:15 -0800 [thread overview]
Message-ID: <xmqqbn9rffo0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151215233207.GA30294@sigill.intra.peff.net> (Jeff King's message of "Tue, 15 Dec 2015 18:32:07 -0500")
Jeff King <peff@peff.net> writes:
>> * jc/strbuf-gets (2015-10-28) 17 commits
>> [...]
>>
>> Teach codepaths that communicate with users by reading text files
>> to be more lenient to editors that write CRLF-terminated lines.
>> Note that this is only about communication with Git, like feeding
>> list of object names from the standard input instead of from the
>> command line, and does not involve files in the working tree.
>>
>> Waiting for review.
>
> I like the intent here, but I was a little disappointed that we end up
> with two almost identical strbuf functions. But even if the ultimate
> endgame is to drop back to one, the conservative route is to keep them
> both until all new code paths have "opted in" to the new behavior.
> However, I found the naming confusing: it was not at all clear to me
> which of strbuf_gets and strbuf_getline did the CRLF-munging. Perhaps
> it would be more obvious if the new one was strbuf_getline_crlf or
> something. I dunno.
There already was strbuf_getline_crlf(), and I wanted a new name to
be conservative. It was modelled after gets() (not fgets()) that
removes the trailing line terminator, but there may have been better
names. I dunno, either.
Thanks.
next prev parent reply other threads:[~2015-12-15 23:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 22:48 What's cooking in git.git (Dec 2015, #05; Tue, 15) Junio C Hamano
2015-12-15 23:16 ` Stefan Beller
2015-12-15 23:32 ` Jeff King
2015-12-15 23:34 ` Junio C Hamano
2015-12-15 23:36 ` Junio C Hamano [this message]
2015-12-15 23:44 ` Junio C Hamano
2015-12-16 0:50 ` Jeff King
2015-12-16 15:58 ` Johannes Schindelin
2015-12-16 6:58 ` Torsten Bögershausen
2015-12-16 18:04 ` Junio C Hamano
2015-12-21 15:31 ` Torsten Bögershausen
2015-12-18 13:23 ` SZEDER Gábor
2015-12-21 16:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbn9rffo0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).