git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Re: [PATCH] index-pack: --clone-bundle option
Date: Thu, 03 Mar 2016 15:20:20 -0800	[thread overview]
Message-ID: <xmqqbn6v174b.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqfuw7186z.fsf_-_@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 03 Mar 2016 14:57:08 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> Note that this name choice does not matter very much in the larger
> picture.  As an initial clone that bootstraps from a clone-bundle is
> expected to do a rough equivalent of:
>
>     # create a new repository
>     git init new-repository &&
>     git remote add origin $URL &&
>
>     # prime the object store and anchor the history to temporary
>     # references
>     git fetch $bundle 'refs/*:refs/temporary/*' &&
>
>     # fetch the more recent history from the true origin
>     git fetch origin &&
>     git checkout -f &&
>
>     # remove the temporary refs
>     git for-each-ref -z --format=%(refname) refs/temporary/ |
>     xargs -0 git update-ref -d
>
> the names recorded in the bundle will not really matter to the end
> result.

Actually, the real implementation of "bootstrap with clone-bundle"
is more likely to go like this:

    * The client gets redirected to $name.bndl file, and obtains a
      fairly full $name.pack file by downloading them as static
      files;

    * The client initializes an empty repository;

    * The pack file is stored at .git/objects/pack/pack-$sha1.pack;

    * When the client does a "git fetch origin" to fill the more
      recent part, fetch-pack.c::find_common() would read from the
      "git bundle list-heads $name.bndl" to learn the "reference"
      objects.  These are thrown at rev_list_insert_ref() and are
      advertised as "have"s, just like we advertise objects at the
      tip of refs in alternate repository.

So there will be no refs/temporary/* hierarchy we would need to
worry about cleaning up.

Another possible variant is to redirect the client directly to
download pack-$sha1.pack; "index-pack" needs to be run on the client
side anyway to create pack-$sha1.idx, so at that time it could do
the equivalent of "--clone-bundle" processing (it is not strictly
necessary to create a split bundle) to find the tips of histories,
and use that information when running "git fetch origin".

So, even though I started working from "split bundle", we may not
have to have such a feature after all to support CDN offloadable and
resumable clone.

  reply	other threads:[~2016-03-03 23:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 19:14 [PATCH] index-pack: correct --keep[=<msg>] Junio C Hamano
2016-03-03 19:47 ` Jeff King
2016-03-03 21:37 ` [PATCH] index-pack: add a helper function to derive .idx/.keep filename Junio C Hamano
2016-03-03 22:29   ` Jeff King
2016-03-03 22:57     ` [PATCH] index-pack: --clone-bundle option Junio C Hamano
2016-03-03 23:20       ` Junio C Hamano [this message]
2016-03-04 15:51         ` Jeff King
2016-03-04 15:34       ` Jeff King
2016-03-03 21:44 ` [PATCH] index-pack: correct --keep[=<msg>] Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbn6v174b.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).