From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Stefan Beller <sbeller@google.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: t5545: reduced test coverage
Date: Wed, 17 May 2017 11:40:12 +0900 [thread overview]
Message-ID: <xmqqbmqsyzn7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <ca942ab1-db57-5794-4587-1a756686c833@ramsayjones.plus.com> (Ramsay Jones's message of "Tue, 16 May 2017 16:55:43 +0100")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Hi Junio,
>
> I noticed, when comparing the test-suite output from v2.12.0
> versus v2.13.0-rc0 on cygwin, that t5545-push-options.sh was
> no longer being run. (Well, now being skipped because it can't
> find a web-server). Prior to commit 438fc68462 ("push options:
> pass push options to the transport helper", 08-02-2017), this
> test file ran three tests on 'local remotes'.
>
> [I used to test with apache on Linux, but during an OS upgrade
> (some time ago) I decided not to install apache just for the
> git test-suite. (I used to run webgit and cgit, but no more!)]
>
> I suppose it is not a major reduction in test coverage, but I
> don't recall any discussion about it and I wondered if it was
> by accident or design.
>
> ATB,
> Ramsay Jones
I think it was combination of carelessness and not caring about an
incomplete platform environment well enough.
It appears to me that only a few tests in the entire script wants to
work with HTTP server, so perhaps moving them to the end, together
with the inclusion of lib-httpd and start_httpd that 438fc684 ("push
options: pass push options to the transport helper", 2017-02-08)
introduced, may be sufficient?
Thanks.
next prev parent reply other threads:[~2017-05-17 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 15:55 t5545: reduced test coverage Ramsay Jones
2017-05-17 2:40 ` Junio C Hamano [this message]
2017-05-17 3:11 ` [PATCH] t5545: enhance test coverage when no http server is installed Stefan Beller
2017-05-17 3:56 ` t5545: reduced test coverage Junio C Hamano
2017-05-17 4:23 ` Junio C Hamano
2017-05-17 20:48 ` Ramsay Jones
2017-05-18 2:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmqsyzn7.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).