git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Jeffrey Walton" <noloader@gmail.com>,
	"Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>,
	"J Smith" <dark.panda@gmail.com>,
	"Victor Leschuk" <vleschuk@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Fredrik Kuivinen" <frekui@gmail.com>,
	"Brandon Williams" <bmwill@google.com>,
	"Stefan Beller" <sbeller@google.com>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes
Date: Fri, 02 Jun 2017 08:30:24 +0900	[thread overview]
Message-ID: <xmqqbmq74773.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170601182056.31142-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 1 Jun 2017 18:20:48 +0000")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> See <20170525200528.22037-1-avarab@gmail.com> for v3
> (https://public-inbox.org/git/20170525200528.22037-1-avarab@gmail.com/).
>
> This is on top of "[PATCH v4 00/31] Easy to review grep & pre-PCRE
> changes".
>
> Changes:
>
> Ævar Arnfjörð Bjarmason (8):
>   grep: don't redundantly compile throwaway patterns under threading
>   grep: skip pthreads overhead when using one thread
>   log: add -P as a synonym for --perl-regexp
>   grep: add support for the PCRE v1 JIT API
>   grep: un-break building with PCRE < 8.32
>   grep: un-break building with PCRE < 8.20
>
> No changes.
>
>   grep: un-break building with PCRE >= 8.32 without --enable-jit
>
> NEW: It turns out that a PCRE version that supports JIT, but is built
> without JIT support will fail at link time since there's no
> pcre_jit_exec symbol.
>
> It also turns out (contrary to what I claimed on list before, my
> mistake) that there's no way to detect this through some macro. All
> the pcre include files are the same with/without --enable-jit, only
> the object file differs.
>
> So there's now a NO_LIBPCRE1_JIT flag to the Makefile, which is off by
> default, but turned on on MinGW. I have not tested that
> config.mak.uname change, but everything else I could test on Linux.
>
> The reason for why it's NO_LIBPCRE1_JIT not USE_LIBPCRE1_JIT is that
> in practice pretty much everyone who builds pcre builds it with JIT
> (I've looked through various Linux/BSD distro build files), it's MinGW
> that's the exception here. Given the performance gain it makes sense
> to make it the default.
>
>   grep: add support for PCRE v2
>
> Almost no changes, just:
>
>  * A trivial change to stop redundantly assigning to pcre2_jit_on,
>    mistakenly left over from an earlier version.
>
>  * Updated commit message / perf numbers for the extra patches in the
>    series both here and in v3.

Nicely summarised and matches what I received; thanks, will replace.

  parent reply	other threads:[~2017-06-01 23:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 18:20 [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 1/8] grep: don't redundantly compile throwaway patterns under threading Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 2/8] grep: skip pthreads overhead when using one thread Ævar Arnfjörð Bjarmason
2017-06-01 21:20   ` Stefan Beller
2017-06-01 21:36     ` Ævar Arnfjörð Bjarmason
2017-06-01 21:38       ` Ævar Arnfjörð Bjarmason
2017-06-01 21:45         ` Stefan Beller
2017-06-01 21:55           ` Ævar Arnfjörð Bjarmason
2017-06-01 22:08             ` Stefan Beller
2017-06-01 18:20 ` [PATCH v4 3/8] log: add -P as a synonym for --perl-regexp Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 4/8] grep: add support for the PCRE v1 JIT API Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 5/8] grep: un-break building with PCRE < 8.32 Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 6/8] grep: un-break building with PCRE < 8.20 Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 7/8] grep: un-break building with PCRE >= 8.32 without --enable-jit Ævar Arnfjörð Bjarmason
2017-06-01 18:20 ` [PATCH v4 8/8] grep: add support for PCRE v2 Ævar Arnfjörð Bjarmason
2017-06-01 23:30 ` Junio C Hamano [this message]
2017-06-02 16:10   ` [PATCH v4 0/8] PCRE v2, PCRE v1 JIT, log -P & fixes Johannes Schindelin
2017-06-02 16:45     ` Ævar Arnfjörð Bjarmason
2017-06-05  0:38       ` Junio C Hamano
2017-06-07 15:50         ` Johannes Schindelin
2017-06-07 16:14           ` Ævar Arnfjörð Bjarmason
2017-06-09 13:09             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbmq74773.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bmwill@google.com \
    --cc=dark.panda@gmail.com \
    --cc=frekui@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=michal.kiedrowicz@gmail.com \
    --cc=noloader@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    --cc=vleschuk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).