git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] RelNotes: add more notes about PCRE in 2.14
Date: Thu, 20 Jul 2017 12:11:02 -0700	[thread overview]
Message-ID: <xmqqbmoely9l.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170720141927.18274-7-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 20 Jul 2017 14:19:27 +0000")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> We were missing any mention that:
>
>  - PCRE is now faster with JIT
>  - That it's now faster than the other regex backends
>  - That therefore you might want to use it by default, but beware of
>    the incompatible syntax.

Hmph.  All of that has been more or less deliberate, as I want the
release notes to be more like table of contents, one bullet per item
with short description, not a novelette with one paragraph per item.

These should already be in the documentation when they do want to
decide if they want to use JIT; somebody who downloads 2.15 or later
and wants to decide if they want JIT shouldn't have to dig down to
earlier release notes that introduced the option for the first time.

> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Documentation/RelNotes/2.14.0.txt | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/RelNotes/2.14.0.txt b/Documentation/RelNotes/2.14.0.txt
> index fb6a3dba31..a6a1cb963b 100644
> --- a/Documentation/RelNotes/2.14.0.txt
> +++ b/Documentation/RelNotes/2.14.0.txt
> @@ -88,7 +88,16 @@ UI, Workflows & Features
>     learned to say "it's a pathspec" a bit more often when the syntax
>     looks like so.
>  
> - * Update "perl-compatible regular expression" support to enable JIT.
> + * Update "perl-compatible regular expression" support to enable
> +   JIT.
> +
> +   This makes grep.patternType=perl (and -P and --perl-regexp) much
> +   faster for "git grep" and "git log", and is generally faster than
> +   the system's POSIX regular expression implementation. Users
> +   concerned with "git grep" performance or "git log --grep"
> +   performance might want to try setting grep.patternType=perl. Note
> +   that the syntax isn't compatible with git's default of
> +   grep.patternType=basic.
>  
>   * "filter-branch" learned a pseudo filter "--setup" that can be used
>     to define common functions/variables that can be used by other

      reply	other threads:[~2017-07-20 19:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 23:43 [ANNOUNCE] Git v2.14.0-rc0 Junio C Hamano
2017-07-14 23:17 ` Ævar Arnfjörð Bjarmason
2017-07-15  4:09   ` Christian Couder
2017-07-15 10:09     ` Ævar Arnfjörð Bjarmason
2017-07-17 20:41   ` Junio C Hamano
2017-07-18 20:03     ` Junio C Hamano
2017-07-20 14:19     ` [PATCH 0/6] 2.14 RelNotes improvements Ævar Arnfjörð Bjarmason
2017-07-20 20:35       ` Junio C Hamano
2017-07-21 11:03         ` Ævar Arnfjörð Bjarmason
2017-07-20 14:19     ` [PATCH 1/6] RelNotes: mention "log: add -P as a synonym for --perl-regexp" Ævar Arnfjörð Bjarmason
2017-07-20 14:19     ` [PATCH 2/6] RelNotes: mention "log: make --regexp-ignore-case work with --perl-regexp" Ævar Arnfjörð Bjarmason
2017-07-20 14:19     ` [PATCH 3/6] RelNotes: mention "sha1dc: optionally use sha1collisiondetection as a submodule" Ævar Arnfjörð Bjarmason
2017-07-20 14:19     ` [PATCH 4/6] RelNotes: mention that PCRE v2 exposes the same syntax Ævar Arnfjörð Bjarmason
2017-07-20 15:24       ` Junio C Hamano
2017-07-20 14:19     ` [PATCH 5/6] RelNotes: remove duplicate mention of PCRE v2 Ævar Arnfjörð Bjarmason
2017-07-20 15:26       ` Junio C Hamano
2017-07-20 14:19     ` [PATCH 6/6] RelNotes: add more notes about PCRE in 2.14 Ævar Arnfjörð Bjarmason
2017-07-20 19:11       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbmoely9l.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).