From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Ben Peart" <peartben@gmail.com>,
"Brandon Williams" <bmwill@google.com>,
"Ben Peart" <benpeart@microsoft.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v1] dir.c: don't flag the index as dirty for changes to the untracked cache
Date: Tue, 06 Feb 2018 06:50:57 -0800 [thread overview]
Message-ID: <xmqqbmh2894e.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8DLP=j-h3knwX9zOpejAfUbv1YJwfB-iw4476oy0hTfxg@mail.gmail.com> (Duy Nguyen's message of "Tue, 6 Feb 2018 19:27:07 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> Please don't do that, at least not this way. cache_changed mask should
> reflect all dirty parts in .git/index. If UNTR extension is not marked
> updated, it's legit to just skip generating/writing it down (e.g. if I
> kept the old UNTR extension from the last time I read .git/index
> around in memory)
Excellent point. Thanks for mentioning this (it crossed my mind
when I responded but I forgot to metion in my message).
next prev parent reply other threads:[~2018-02-06 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 19:56 [PATCH v1] dir.c: don't flag the index as dirty for changes to the untracked cache Ben Peart
2018-02-05 20:55 ` Junio C Hamano
2018-02-06 1:39 ` Ben Peart
2018-02-05 21:58 ` Brandon Williams
2018-02-06 1:48 ` Ben Peart
2018-02-06 12:27 ` Duy Nguyen
2018-02-06 12:55 ` Duy Nguyen
2018-02-07 10:59 ` Duy Nguyen
2018-02-07 13:46 ` Ben Peart
2018-02-06 14:50 ` Junio C Hamano [this message]
2018-02-07 14:13 ` Ben Peart
2018-02-12 10:20 ` Duy Nguyen
2018-02-12 17:57 ` Ben Peart
2018-02-13 9:57 ` Duy Nguyen
2018-02-08 10:33 ` Jeff King
2018-02-28 21:27 ` Junio C Hamano
2018-03-01 7:42 ` Jeff King
2018-03-01 12:35 ` Ben Peart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmh2894e.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=benpeart@microsoft.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).