From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] http: don't leak urlmatch_config.vars
Date: Mon, 26 Aug 2019 11:09:56 -0700 [thread overview]
Message-ID: <xmqqblwbhk7f.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190826074911.23792-1-mh@glandium.org> (Mike Hommey's message of "Mon, 26 Aug 2019 16:49:11 +0900")
Mike Hommey <mh@glandium.org> writes:
> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---
> http.c | 1 +
> 1 file changed, 1 insertion(+)
This matches what builtin/config.c::get_urlmatch() does, which makes
sense.
Thanks.
>
> diff --git a/http.c b/http.c
> index 27aa0a3192..9e33584f2d 100644
> --- a/http.c
> +++ b/http.c
> @@ -1073,6 +1073,7 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
>
> git_config(urlmatch_config_entry, &config);
> free(normalized_url);
> + string_list_clear(&config.vars, 1);
>
> #if LIBCURL_VERSION_NUM >= 0x073800
> if (http_ssl_backend) {
prev parent reply other threads:[~2019-08-26 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 7:49 [PATCH] http: don't leak urlmatch_config.vars Mike Hommey
2019-08-26 18:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblwbhk7f.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).