mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Miriam Rubio <>
Cc:, Tanushree Tumane <>,
	Christian Couder <>
Subject: Re: [Outreachy] [PATCH] bisect--helper: convert `*_warning` char pointers to char arrays.
Date: Fri, 13 Dec 2019 11:57:42 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Miriam Rubio's message of "Fri, 13 Dec 2019 12:52:25 +0100")

Miriam Rubio <> writes:

> From: Tanushree Tumane <>
> A char array creates a character array. Its size is the number
> of elements plus one (compiler automatically adds '\0').
> A char pointer creates a char array and a pointer to that char
> array that means four extra for bytes for the pointer variable.

This depends on the word size of your pointer and many people have
8-byte pointers these days.  Just say

	Instead of using a pointer that points at a constant string,
	just give name directly to the constant string; this way, we
	do not have to allocate a pointer variable in addition to
	the string we want to use.

or something.

> Let's convert `need_bad_and_good_revision_warning` and
> `need_bisect_start_warning` char pointers to char arrays.
> Mentored-by: Christian Couder <>
> Signed-off-by: Tanushree Tumane <>
> Signed-off-by: Miriam Rubio <>
> ---
> This patch is a new version of:
> sent previously by Tanushree.
>  builtin/bisect--helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 3055b2bb50..1718df7f09 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -282,11 +282,11 @@ static int mark_good(const char *refname, const struct object_id *oid,
>  	return 1;
>  }
> -static const char *need_bad_and_good_revision_warning =
> +static const char need_bad_and_good_revision_warning[] =
>  	N_("You need to give me at least one %s and %s revision.\n"
>  	   "You can use \"git bisect %s\" and \"git bisect %s\" for that.");
> -static const char *need_bisect_start_warning =
> +static const char need_bisect_start_warning[] =
>  	N_("You need to start by \"git bisect start\".\n"
>  	   "You then need to give me at least one %s and %s revision.\n"
>  	   "You can use \"git bisect %s\" and \"git bisect %s\" for that.");

  reply	other threads:[~2019-12-13 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 11:52 [Outreachy] [PATCH] bisect--helper: convert `*_warning` char pointers to char arrays Miriam Rubio
2019-12-13 19:57 ` Junio C Hamano [this message]
2019-12-14  8:09   ` Miriam R.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).