From: Junio C Hamano <gitster@pobox.com>
To: Damien Robert <damien.olivier.robert@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
William Baker <William.Baker@microsoft.com>,
Damien Robert <damien.olivier.robert+git@gmail.com>
Subject: Re: [PATCH v4 1/1] midx.c: fix an integer overflow
Date: Thu, 26 Mar 2020 16:27:16 -0700 [thread overview]
Message-ID: <xmqqbloiitnv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200326213534.399377-1-damien.olivier.robert+git@gmail.com> (Damien Robert's message of "Thu, 26 Mar 2020 22:35:34 +0100")
Damien Robert <damien.olivier.robert@gmail.com> writes:
> When verifying a midx index with 0 objects, the
> m->num_objects - 1
> overflows to 4294967295.
I think this is underflow & wraparound, but I'll let it pass ;-)
The patch looks good; will queue.
Thanks.
next prev parent reply other threads:[~2020-03-26 23:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 16:24 [PATCH 1/1] midx.c: fix an integer overflow Damien Robert
2020-02-28 18:55 ` Jeff King
2020-02-28 20:39 ` Junio C Hamano
2020-02-29 17:15 ` Damien Robert
2020-02-29 15:38 ` Damien Robert
2020-03-12 17:35 ` [PATCH v2 " Damien Robert
2020-03-12 18:24 ` Damien Robert
2020-03-12 18:28 ` Derrick Stolee
2020-03-12 21:41 ` Damien Robert
2020-03-23 22:25 ` [PATCH v3 " Damien Robert
2020-03-24 6:01 ` Jeff King
2020-03-24 18:48 ` Junio C Hamano
2020-03-26 21:35 ` [PATCH v4 " Damien Robert
2020-03-26 23:27 ` Junio C Hamano [this message]
2020-03-28 22:23 ` Damien Robert
2020-03-28 23:51 ` Junio C Hamano
2020-03-28 22:18 ` [PATCH 1/1] midx.c: fix an integer underflow Damien Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbloiitnv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=William.Baker@microsoft.com \
--cc=damien.olivier.robert+git@gmail.com \
--cc=damien.olivier.robert@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).