From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 28E441F5AE for ; Fri, 19 Jun 2020 16:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395250AbgFSQf7 (ORCPT ); Fri, 19 Jun 2020 12:35:59 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60923 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395240AbgFSQf5 (ORCPT ); Fri, 19 Jun 2020 12:35:57 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CC1605FAFB; Fri, 19 Jun 2020 12:35:54 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=HQQYmILpsk6E bKsVDkDhO5QUtpw=; b=cmEDg2d9ZFa/GaSwryT5ysX0yaQnQbxU/7mTkCKnL3ph TFFa4yr2b0Ggqpf9joAlQhVME3p1XzK1r8BoyD8ctqMsSNtxqdrZr8og1elOlJld MzECFAcgiv79vZEK0Si5wRMtxNk5ER9qe3w65tu8PH4yKp1FAZXxUyq7VulGL6U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=pTNsM+ ExYuj95Wb4kVHDC6B4trXGrKZY+KUo1Sfx7yoHPP7rTxc4fXJklhmyLAeCvIxdKn wowI7ntlWHGxi/3fM+6JS8TR/MFLF+qy4WOzliir3LMEIhYZYIiz8Kjt7+580xij ixW2zd9V9UVy20ONw6T3HL4ZjbcC8A/XMWSPs= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C3A4A5FAF9; Fri, 19 Jun 2020 12:35:54 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.231.104.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 41FE65FAF8; Fri, 19 Jun 2020 12:35:54 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: SZEDER =?utf-8?Q?G=C3=A1bor?= Cc: Elijah Newren via GitGitGadget , git@vger.kernel.org, dstolee@microsoft.com, Elijah Newren Subject: Re: [PATCH v2 2/2] git-prompt: include sparsity state as well References: <17254b30a5bcbbe3e14dd47272dfcb4c867030dd.1592513398.git.gitgitgadget@gmail.com> <20200619161528.GI2898@szeder.dev> Date: Fri, 19 Jun 2020 09:35:53 -0700 In-Reply-To: (Junio C. Hamano's message of "Fri, 19 Jun 2020 09:33:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: F1D63410-B24A-11EA-9B34-C28CBED8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > SZEDER G=C3=A1bor writes: > >>> + local sparse=3D"" >>> + if [ "$(git config --bool core.sparseCheckout)" =3D=3D "true" ]; th= en >>> + sparse=3D"|SPARSE" >> >> Nit: indentation. > > Also, do we want "=3D=3D" there? I thought [ ... ] (unlike [[ ... ]]) > was a mere synonym for "test", to which "=3D=3D" is a bug. Ah, OK, this script is very bash specific so POSIX portability rules do not matter. =3D=3D is just fine as =3D there. Sorry for the noise.