git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: users@kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [RFD] on removing "git-foo" for builtins from disk
Date: Mon, 24 Aug 2020 15:23:39 -0700	[thread overview]
Message-ID: <xmqqbliz3cpg.fsf@gitster.c.googlers.com> (raw)

Back in 2005, all "git" subcommands were installed in $PATH as
"git-commit" etc., and people wrote their scripts assuming that they
are all available on their $PATH.  But it then became cumbersome to
have so many "git-foo" commands in /usr/bin/.  Because "git" is
installed in /usr/bin/ and knows to dispatch to 'git-foo' subcommand
when invoked with 'foo' as its first argument, we asked our users to
use "git foo" form and moved "git-foo" commands out of /usr/bin/,
moved to /usr/libexec/git-core/, and gave an escape hatch, which is
to add the output of "git --exec-path" early in their $PATH, to old
scripts (i.e. the scripts needed a one-line fix).

Exectly 12 years ago, we asked the users if they still need these
on-disk binaries [*1*].  Many built-in commands (i.e. subcommands
whose code is in the "git" binary), as long as they are invoked in
"git foo" form, do not need to be installed anywhere on-disk, and
theoretically can be removed, as long as the users and the scripts
they wrote long time ago, following our advise to use the escape
hatch, can somehow be convinced.

Removing /usr/libexec/git-core/git-{add,branch,commit,...} will
allow us to reduce disk footprint on systems that do not support
hardlinks and slightly simplifies the installation procedure.  Some
folks want to do so unconditionally.  The only downside being that
we finally break the promise we made our users 12 years ago.

I do not have a strong opinion either way, but if proponents for
removal can convince others successfully, I do not mind removing the
unnecessary on-disk binaries for built-in commands.

Discuss away.


[References and Footnotes]

*1* https://lore.kernel.org/git/7vprnzt7d5.fsf@gitster.siamese.dyndns.org/

                 reply	other threads:[~2020-08-24 22:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbliz3cpg.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=users@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).