From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [RFC] CodingGuidelines: mark external declarations with "extern"
Date: Fri, 09 Oct 2020 16:05:47 -0700 [thread overview]
Message-ID: <xmqqblhbrodw.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201009230033.GA31120@generichostname> (Denton Liu's message of "Fri, 9 Oct 2020 16:00:33 -0700")
Denton Liu <liu.denton@gmail.com> writes:
>> And I have a strong preference, after thinking about it, to have
>> "extern" in front in the declarations. It gives another clue for
>> patterns I feed to "git grep" to latch onto, and help my eyes to
>> scan and tell decls and defns apart in the output. The benefit
>> alone is worth the extra 7 columns in front spent, which you call
>> "clutter".
>
> To be honest, I do not have any preference between having the explicit
> extern or not. I do have a strong preference, however, for having a
> codebase that's consistently written. When I was doing the refactor, I
> wouldn't have minded introducing extern everywhere although that wasn't
> suggested as an alternative.
>
> I agree that these are all benefits of declaring functions explicitly as
> extern. However, I don't think they're worth the cost of either another
> huge rewrite or an inconsistent codebase.
Yes, there is a cost associated with having made a mistake in the
past. Biting the bullet now, perhaps as the first tree-wide change
immediately after the upcoming release, while the tree is quiescent,
would help us in the longer term, than having to live without extern
on declarations.
next prev parent reply other threads:[~2020-10-09 23:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:27 [PATCH] clean up extern decl of functions Junio C Hamano
2020-10-09 1:55 ` Denton Liu
2020-10-09 2:47 ` Junio C Hamano
2020-10-09 19:26 ` Junio C Hamano
2020-10-09 19:27 ` [RFC] CodingGuidelines: mark external declarations with "extern" Junio C Hamano
2020-10-09 19:57 ` Jeff King
2020-10-09 20:33 ` Junio C Hamano
2020-10-09 23:00 ` Denton Liu
2020-10-09 23:05 ` Junio C Hamano [this message]
2020-10-10 0:37 ` Đoàn Trần Công Danh
2020-10-15 1:36 ` Jeff King
2020-10-15 17:15 ` Junio C Hamano
2020-10-15 19:28 ` Jeff King
2020-10-15 19:30 ` [PATCH v2 1/2] usage: define a type for a reporting function Jeff King
2020-10-15 19:30 ` [PATCH v2 2/2] config.mak.dev: build with -fno-common Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblhbrodw.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).