mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Eric Sunshine <>
Cc: "SZEDER Gábor" <>, "Git List" <>
Subject: Re: git format-patch --range-diff bug?
Date: Thu, 12 Nov 2020 10:59:50 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Eric Sunshine's message of "Thu, 12 Nov 2020 13:32:42 -0500")

Eric Sunshine <> writes:

> I haven't fully thought it through yet, but at this point, the best
> "fix" likely would be for `git format-patch --range-diff` to error out
> when it sees a 3-dot range. (Unless there is some other intuitive
> interpretation of a 3-dot range which escapes me.)

And possibly rename the option.  Giving "--range-diff=<prev>" is not
an instruction to run "git range-diff <prev>", so it is clear that
the option is misnamed.

It probably should have been "--[no-]range-diff" boolean that
controls if we add the range-diff from the previous, whose default
may be affected by the user of the "-v$n" option, plus another
option that gives where to find the "previous series", whose
presence probably trigger "--range-diff" implicitly, or something
like that.

And the option whose value we are having problem with is exactly
that "--previous-series=<prev>" option.

  reply	other threads:[~2020-11-12 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12 17:43 git format-patch --range-diff bug? SZEDER Gábor
2020-11-12 17:57 ` Junio C Hamano
2020-11-12 18:32   ` Eric Sunshine
2020-11-12 18:59     ` Junio C Hamano [this message]
2020-11-12 20:06       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).