From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, "Git List" <git@vger.kernel.org>
Subject: Re: git format-patch --range-diff bug?
Date: Thu, 12 Nov 2020 10:59:50 -0800 [thread overview]
Message-ID: <xmqqblg2jt95.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cT1zDT1iqRqO-4U8Rwq7p=MFm5Bkn990AVbxMHqp=knmg@mail.gmail.com> (Eric Sunshine's message of "Thu, 12 Nov 2020 13:32:42 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> I haven't fully thought it through yet, but at this point, the best
> "fix" likely would be for `git format-patch --range-diff` to error out
> when it sees a 3-dot range. (Unless there is some other intuitive
> interpretation of a 3-dot range which escapes me.)
And possibly rename the option. Giving "--range-diff=<prev>" is not
an instruction to run "git range-diff <prev>", so it is clear that
the option is misnamed.
It probably should have been "--[no-]range-diff" boolean that
controls if we add the range-diff from the previous, whose default
may be affected by the user of the "-v$n" option, plus another
option that gives where to find the "previous series", whose
presence probably trigger "--range-diff" implicitly, or something
like that.
And the option whose value we are having problem with is exactly
that "--previous-series=<prev>" option.
next prev parent reply other threads:[~2020-11-12 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 17:43 git format-patch --range-diff bug? SZEDER Gábor
2020-11-12 17:57 ` Junio C Hamano
2020-11-12 18:32 ` Eric Sunshine
2020-11-12 18:59 ` Junio C Hamano [this message]
2020-11-12 20:06 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblg2jt95.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).