From: Junio C Hamano <gitster@pobox.com>
To: Samuel Yvon <samuelyvon9@gmail.com>
Cc: avarab@gmail.com, git@vger.kernel.org, gitgitgadget@gmail.com
Subject: Re: [PATCH] builtin-commit: re-read file index before launching editor
Date: Tue, 09 Nov 2021 10:36:30 -0800 [thread overview]
Message-ID: <xmqqbl2t2n2p.fsf@gitster.g> (raw)
In-Reply-To: <20211109152219.11037-1-samuelyvon9@gmail.com> (Samuel Yvon's message of "Tue, 9 Nov 2021 10:22:19 -0500")
Samuel Yvon <samuelyvon9@gmail.com> writes:
> On one hand, flushing then showing the editor seems to indicate that we want the
> editor to be up-to-date, but because the status is prepared before the flushing,
> maybe not?
>
> While it seems the current behaviour has been the behaviour since the start,
> I am inclined to continue pushing for this change. Unless I am missing something,
> the comment is contradictory and we should be coherent with the idea of
> accepting changes made within the pre-commit hook, as noted in
> https://lore.kernel.org/git/xmqqk0yripca.fsf@gitster.c.googlers.com/t/#u:
>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>> Even before ec84bd00 (git-commit: Refactor creation of log message.,
>>> 2008-02-05), the code anticipated that pre-commit may touch the index
>>> and tried to cope with it.
You seem to be quoting the thread over and over, but what you are
quoting is somewhat different from the concluding part of what I
said, which was:
If I have to guess, I think the reason is because pre-commit
automation is expected to be some sort of mechanical change and
not part of the actual work that the end-user produced, it would
become easier to perform the "final review" of "what have I done
so far---does everything make sense?" if such "extra" changes
are excluded.
So, in short, it is not "undefined", but rather it seems to be a
designed behaviour that we are seeing.
I do not personally mind if we change the philosophy but because it
has been a longstanding designed behaviour, it may need a careful
transition plan.
next prev parent reply other threads:[~2021-11-09 18:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:06 [PATCH] builtin-commit: re-read file index before launching editor Samuel Yvon via GitGitGadget
2021-11-09 2:32 ` Ævar Arnfjörð Bjarmason
2021-11-09 3:08 ` samuelyvon9
2021-11-09 9:11 ` Ævar Arnfjörð Bjarmason
2021-11-09 15:22 ` Samuel Yvon
2021-11-09 18:36 ` Junio C Hamano [this message]
2021-11-09 20:01 ` Samuel Yvon
2021-11-11 22:09 ` Junio C Hamano
2021-11-09 16:41 ` Description of github.com/git/git, was " Johannes Schindelin
2021-11-09 17:01 ` Samuel Yvon
2021-11-09 19:03 ` Junio C Hamano
2021-11-09 19:23 ` Taylor Blau
2021-11-09 19:27 ` Samuel Yvon
2021-11-10 12:22 ` Johannes Schindelin
2021-11-11 17:55 ` [PATCH v2] builtin-commit: re-read file index before run_status Samuel Yvon via GitGitGadget
2021-11-12 23:23 ` Junio C Hamano
2021-11-17 16:48 ` Samuel Yvon
2021-11-18 23:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbl2t2n2p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=samuelyvon9@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).