From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=0.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 32FE61FA00 for ; Tue, 8 Feb 2022 01:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238774AbiBHBFQ (ORCPT ); Mon, 7 Feb 2022 20:05:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236211AbiBGXaq (ORCPT ); Mon, 7 Feb 2022 18:30:46 -0500 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41BCBC061355 for ; Mon, 7 Feb 2022 15:30:43 -0800 (PST) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 56F2811BA27; Mon, 7 Feb 2022 18:30:42 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=IMch9IwPUF0u S85ARXQ0J6giBdCjAYM8zzQFFVtZ7s4=; b=wrMhyFsIAz+bnAISGER9HpMzA2ps SNoj4Dqoif5ptTXC0i0D2Lx/e7AoOZsrZxtOrnRWAnZhUIBU6cHHeEY1pxdDxHdJ DbN5fnCqmW5AiX9F2TZuIq2/tZhmcHS3VyNtHuTQ1w3FTr7AOba6OqJMpsypa4zc Z9b9LfTQ7Y0nLlE= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4DD8011BA26; Mon, 7 Feb 2022 18:30:42 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.185.212.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id AD6FF11BA25; Mon, 7 Feb 2022 18:30:41 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?Q?Ren=C3=A9?= Scharfe Cc: Johannes Schindelin via GitGitGadget , git@vger.kernel.org, Taylor Blau , Derrick Stolee , Elijah Newren , Johannes Schindelin Subject: Re: [PATCH v2 1/6] archive: optionally add "virtual" files References: <49ff3c1f2b32b16df2b4216aa016d715b6de46bc.1644187146.git.gitgitgadget@gmail.com> Date: Mon, 07 Feb 2022 15:30:40 -0800 In-Reply-To: (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Mon, 7 Feb 2022 20:55:02 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: F6EE67EC-886D-11EC-8B93-5E84C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ren=C3=A9 Scharfe writes: > We could use that option in Git's own Makefile to add the file named > "version", which contains $GIT_VERSION. Hmm, but it also contains a > terminating newline, which would be a bit tricky (but not impossible) t= o > add. Would it make sense to add one automatically if it's missing (e.g= . > with strbuf_complete_line)? Not sure. I do not think it is a good UI to give raw file content from the command line, which will be usable only for trivial, even single liner files, and forces people to learn two parallel option, one for trivial ones and the other for contents with meaningful size. "--add-blob=3D:" may be another option, useful when you have done "hash-object -w" already, and can be used to add single-liner, or an entire novel. In any case, "--add-file=3D", which we already have, would be more appropriate feature to use to record our "version" file, so there is no need to change our Makefile for it.