From: Junio C Hamano <gitster@pobox.com>
To: Tao Klerks <tao@klerks.biz>
Cc: Tao Klerks via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] untracked-cache: support '--untracked-files=all' if configured
Date: Sun, 27 Feb 2022 11:54:14 -0800 [thread overview]
Message-ID: <xmqqbkys3x21.fsf@gitster.g> (raw)
In-Reply-To: <CAPMMpoixi3x1PHrSHJPV1GRBzMpuOQ4meMr-fipXuDvz-96MEA@mail.gmail.com> (Tao Klerks's message of "Sun, 27 Feb 2022 12:21:30 +0100")
Tao Klerks <tao@klerks.biz> writes:
>> > + configured_dir_flags = configured_default_dir_flags(istate);
>> > + if (dir->flags != configured_dir_flags)
>> > + return NULL;
>>
>> Hmph. If this weren't necessary, this function does not need to
>> call configured_default_dir_flags(), and it can lose the
>> configured_dir_flags variable, too. Which means that
>> new_untracked_cache() function does not need to take the flags word
>> as a caller-supplied parameter. Instead, it can make a call to
>> configured_dir_flags() and assign the result to uc->dir_flags
>> itself, which would have been much nicer.
>
> I've tightened this up a little with an inline call to
> configured_default_dir_flags(), getting rid of the variable, let's see
> if that makes more sense / is cleaner.
The extra variable does not bother me at all. Leaving the room for
the caller to screw up and pass an incorrect configred_dir_flags is
what disturbs me.
If this caller needs to call configred_default_dir_flags(istate),
then we cannot avoid it. And the extra variable needed to call the
function only once, store its result, and use that result twice, is
perfectly a good thing to have. We don't want to see inline or
anything tricky.
Thanks.
next prev parent reply other threads:[~2022-02-27 19:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 6:44 [PATCH] Support untracked cache with '--untracked-files=all' if configured Tao Klerks via GitGitGadget
2022-02-25 17:52 ` [PATCH v2] untracked-cache: support " Tao Klerks via GitGitGadget
2022-02-25 19:43 ` Junio C Hamano
2022-02-27 11:21 ` Tao Klerks
2022-02-27 19:54 ` Junio C Hamano [this message]
2022-02-27 11:22 ` [PATCH v3] " Tao Klerks via GitGitGadget
2022-02-27 14:39 ` Tao Klerks
2022-02-27 15:13 ` [PATCH v4] " Tao Klerks via GitGitGadget
2022-02-28 14:02 ` Ævar Arnfjörð Bjarmason
2022-03-02 8:47 ` Tao Klerks
2022-03-29 11:25 ` [PATCH v5 0/2] Support untracked cache with " Tao Klerks via GitGitGadget
2022-03-29 11:25 ` [PATCH v5 1/2] untracked-cache: test untracked-cache-bypassing behavior with -uall Tao Klerks via GitGitGadget
2022-03-29 16:51 ` Junio C Hamano
2022-03-30 4:46 ` Tao Klerks
2022-03-30 16:39 ` Junio C Hamano
2022-03-31 5:15 ` Tao Klerks
2022-03-29 11:25 ` [PATCH v5 2/2] untracked-cache: support '--untracked-files=all' if configured Tao Klerks via GitGitGadget
2022-03-29 17:43 ` Junio C Hamano
2022-03-30 19:59 ` Tao Klerks
2022-03-31 16:02 ` [PATCH v6 0/2] Support untracked cache with " Tao Klerks via GitGitGadget
2022-03-31 16:02 ` [PATCH v6 1/2] untracked-cache: test untracked-cache-bypassing behavior with -uall Tao Klerks via GitGitGadget
2022-03-31 16:02 ` [PATCH v6 2/2] untracked-cache: support '--untracked-files=all' if configured Tao Klerks via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkys3x21.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).