git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Neeraj Singh <nksingh85@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2022, #06; Mon, 28)
Date: Tue, 29 Mar 2022 16:08:22 -0700	[thread overview]
Message-ID: <xmqqbkxoqrvd.fsf@gitster.g> (raw)
In-Reply-To: <20220329225106.GA12169@neerajsi-x1.localdomain> (Neeraj Singh's message of "Tue, 29 Mar 2022 15:51:06 -0700")

Neeraj Singh <nksingh85@gmail.com> writes:

> On Mon, Mar 28, 2022 at 07:22:47PM -0700, Junio C Hamano wrote:
>> 
>> * ns/core-fsyncmethod (2022-03-15) 6 commits
>>   (merged to 'next' on 2022-03-17 at c8a52f8cbe)
>>  + core.fsync: documentation and user-friendly aggregate options
>>  + core.fsync: new option to harden the index
>>  + core.fsync: add configuration parsing
>>  + core.fsync: introduce granular fsync control infrastructure
>>  + core.fsyncmethod: add writeout-only mode
>>  + wrapper: make inclusion of Windows csprng header tightly scoped
>>  (this branch is used by ns/batch-fsync and ps/fsync-refs.)
>> 
>>  Replace core.fsyncObjectFiles with two new configuration variables,
>>  core.fsync and core.fsyncMethod.
>>  source: <pull.1093.v6.git.1646952204.gitgitgadget@gmail.com>
>> 
>
> There's a fix for this series at:
> https://lore.kernel.org/git/pull.1191.git.1648590113062.gitgitgadget@gmail.com/
> <pull.1191.git.1648590113062.gitgitgadget@gmail.com>
>
> The net effect of the bug being fixed is that anyone using the default
> core.fsync config is syncing everything except loose objects.
>
> Apologies for the bug. I noticed it when revising the perf tests and
> debugging the number of fsyncs. I'm submitting a separate patch to
> log fsync info through trace2.

Thanks.  We should have caught it during the review.

Queued.


      reply	other threads:[~2022-03-29 23:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  2:22 What's cooking in git.git (Mar 2022, #06; Mon, 28) Junio C Hamano
2022-03-29 13:58 ` Jeff Hostetler
2022-03-29 13:59 ` fr/vimdiff-layout (was: What's cooking in git.git (Mar 2022, #06; Mon, 28)) Ævar Arnfjörð Bjarmason
2022-03-29 22:51 ` What's cooking in git.git (Mar 2022, #06; Mon, 28) Neeraj Singh
2022-03-29 23:08   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbkxoqrvd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nksingh85@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).