From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 781B81F4CE for ; Wed, 13 Apr 2022 22:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238899AbiDMW6l (ORCPT ); Wed, 13 Apr 2022 18:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238114AbiDMW6k (ORCPT ); Wed, 13 Apr 2022 18:58:40 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88BB15A586 for ; Wed, 13 Apr 2022 15:56:18 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 0030919CFE7; Wed, 13 Apr 2022 18:56:18 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=anoXdy4bHvlI22acqyLvbzlHzImyjdQMRVzGMT b1hPU=; b=GGiyTn3g3usUuqU4e9LeiJJ+hHvOy08TWuoqk874oW9IoYgfcCmHjp rgPZ91zoNOzT/O2Zc5y+/5N9lnMAnkP7q/pnlEImGJ+YMMmNeiYF/wNFoOTYiwX1 /QiXs9ER+Z1C92bDNOpTgEry1uzMQdwQTg/HBhhb7KzItO6JjT0xE= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id EDAC819CFE6; Wed, 13 Apr 2022 18:56:17 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.185.214.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 5174B19CFE5; Wed, 13 Apr 2022 18:56:15 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Bryan Turner , Git Users , Patrick Steinhardt Subject: Re: reference-transaction regression in 2.36.0-rc1 References: <220413.86r161f3qp.gmgdl@evledraar.gmail.com> Date: Wed, 13 Apr 2022 15:56:14 -0700 In-Reply-To: (Junio C. Hamano's message of "Wed, 13 Apr 2022 15:44:29 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EC1F4088-BB7C-11EC-96DD-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Reverting the merge 991b4d47f0a as a whole is an option. It might > be the safest thing to do, if we do not to want to extend the cycle > and add a few more -rc releases before the final. It turns out that this involves nontrivial amount of work to get right, as the bottom commit of Patrick's "fetch --atomic" series wants to count how many transaction we make, instead of ensuring that the updates to the references are all-or-none, so at least 2a0cafd4 (fetch: increase test coverage of fetches, 2022-02-17) needs to be reverted as well. This in turn is made unnecessarily more cumbersome as the history in the t/ directory is littered with unrelated "clean-up" patches since these topics were merged.