From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Dimitriy Ryazantcev via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jiang Xin <zhiyou.jx@alibaba-inc.com>,
Dimitriy Ryazantcev <dimitriy.ryazantcev@gmail.com>
Subject: Re: [PATCH v2] i18n: mark message helpers prefix for translation
Date: Wed, 22 Jun 2022 08:23:44 -0700 [thread overview]
Message-ID: <xmqqbkuk7mdb.fsf@gitster.g> (raw)
In-Reply-To: <220622.86v8stkt1g.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 22 Jun 2022 10:12:51 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> I posted this patch[1] to do the same a while ago, except it also
> translates the "BUG: " message:
We should take this one, exactly because it does not touch BUG();
the messages given to BUG() are not marked for translation, and
translating only the "BUG:" prefix does not make much sense.
When BUG messages are shown, it is better if they are conveyed back
to us exactly. It would be cumbersome to near-impossible, depending
on the language, if a message was given back to me in a script that
I do not even know how to type---I'd need to map it back via po/*
files with "grep" to locate where the message came from.
Besides, BUG messages are meant not to be seen. We could discuss if
it makes more sense to translate the messages and spend engineering
resource to mark them with _() while massaging the messages to help
deduping, but because the messages are meant primarily for identifying
the locations and not explaining situation to human user, I do not see
a huge benefit doing so.
Thanks.
next prev parent reply other threads:[~2022-06-22 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 13:50 [PATCH] l10n: mark message helpers prefix for translation Dimitriy Ryazantcev via GitGitGadget
2022-06-21 13:57 ` [PATCH v2] i18n: " Dimitriy Ryazantcev via GitGitGadget
2022-06-22 8:12 ` Ævar Arnfjörð Bjarmason
2022-06-22 15:23 ` Junio C Hamano [this message]
2022-06-22 15:33 ` Ævar Arnfjörð Bjarmason
2022-06-21 14:27 ` [PATCH] l10n: " Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkuk7mdb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dimitriy.ryazantcev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).