From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS3215 2.6.0.0/16
X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20])
	by dcvr.yhbt.net (Postfix) with ESMTP id EF8571F54E
	for <e@yhbt.net>; Mon, 11 Jul 2022 20:36:21 +0000 (UTC)
Authentication-Results: dcvr.yhbt.net;
	dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="xCRN+eEi";
	dkim-atps=neutral
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229591AbiGKUgT (ORCPT <rfc822;e@yhbt.net>);
        Mon, 11 Jul 2022 16:36:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59938 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229618AbiGKUgI (ORCPT <rfc822;git@vger.kernel.org>);
        Mon, 11 Jul 2022 16:36:08 -0400
Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 443A67E803
        for <git@vger.kernel.org>; Mon, 11 Jul 2022 13:36:06 -0700 (PDT)
Received: from pb-smtp2.pobox.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 3F644135AD6;
        Mon, 11 Jul 2022 16:36:05 -0400 (EDT)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=t3XKSKUIKvlFj9J+Z60prA+3ex/onqGNPfzPW0
        RLgkE=; b=xCRN+eEiePEWgzd3s+VxLkOTHnKjOtXuU3WtnEFg2IGmA6uf3gExle
        7fsGVs3wwCLhx5atSSjfDksU+PsbfLnf2F+zxVterVg4ZfBN/GxXgwvV3w9Zq3Vd
        kZcKrP56oQVV/vdRLGqKn68LHxMPs6+9oOCeOrTHCGDP0XMFSVRYU=
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp2.pobox.com (Postfix) with ESMTP id 1467A135AD5;
        Mon, 11 Jul 2022 16:36:05 -0400 (EDT)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.83.92.57])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp2.pobox.com (Postfix) with ESMTPSA id C4F5A135AD4;
        Mon, 11 Jul 2022 16:36:03 -0400 (EDT)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Jeff King <peff@peff.net>
Cc:     git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2 4/3] clone: move unborn head creation to update_head()
References: <YsdyLS4UFzj0j/wB@coredump.intra.peff.net>
        <YsdzZxS48u8sk9QD@coredump.intra.peff.net>
        <xmqq8rp3wovj.fsf@gitster.g>
        <YsiF6+RjEsmwviuS@coredump.intra.peff.net>
        <xmqqlet3uyxc.fsf@gitster.g>
        <YsvrsOH1jg559yVt@coredump.intra.peff.net>
Date:   Mon, 11 Jul 2022 13:36:02 -0700
In-Reply-To: <YsvrsOH1jg559yVt@coredump.intra.peff.net> (Jeff King's message
        of "Mon, 11 Jul 2022 05:21:52 -0400")
Message-ID: <xmqqbktvo099.fsf@gitster.g>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 1541ED2C-0159-11ED-B941-CB998F0A682E-77302942!pb-smtp2.pobox.com
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Jeff King <peff@peff.net> writes:

> Let's move the creation of the unborn symref into update_head(). This
> matches the other HEAD-creation cases, and now the logic is consistently
> separated: the main cmd_clone() function only examines the situation and
> sets variables based on what it finds, and update_head() actually
> performs the update.

Yes, this step taken alone, and the final structure of the code,
both look quite sensible.

Thanks, will queue on top.