From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 847D41F54E for ; Wed, 10 Aug 2022 21:25:45 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="Iy5OVvzE"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232786AbiHJVZm (ORCPT ); Wed, 10 Aug 2022 17:25:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233425AbiHJVZj (ORCPT ); Wed, 10 Aug 2022 17:25:39 -0400 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F8011816 for ; Wed, 10 Aug 2022 14:25:37 -0700 (PDT) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id A4B1219F71B; Wed, 10 Aug 2022 17:25:36 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=ojD08yHyNHbDxMaTY892KED1Pk8kdq65BEvuJO 3e5ls=; b=Iy5OVvzEGN6srTvZRFdwnILINpoAf0Or4D206NLD7Eh268euX+Ouhx WrLCmNP3iUagrKp9M5QnVITgfM7OxTNayMFOj0eBaKJbmbaotg3u5dBG4LAXEjxW TcghaXZ6z87UXOP9Z38KCk4sgm5wfXJRE4buy1JDFUAKHMItkdIuo= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 9C29619F71A; Wed, 10 Aug 2022 17:25:36 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.145.39.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 2D23319F719; Wed, 10 Aug 2022 17:25:32 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Li Linchao via GitGitGadget , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Johannes Sixt , Li Linchao Subject: Re: [PATCH v4] rev-list: support human-readable output for `--disk-usage` References: Date: Wed, 10 Aug 2022 14:25:31 -0700 In-Reply-To: (Jeff King's message of "Wed, 10 Aug 2022 17:20:28 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F6E926B8-18F2-11ED-8E37-C85A9F429DF0-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > It was my suggestion to turn it into a helper, because the same code > needs to be present in two distant spots (the bitmap and non-bitmap > cases). > ... > Keep in mind that we are in try_bitmap_disk_usage() here. Yeah, both of them I notice in a later parts of the message you are responding to ;-)