From: Junio C Hamano <gitster@pobox.com>
To: "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, avarab@gmail.com, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH 0/2] check-docs: fix 'diagnose' and 'version'
Date: Mon, 19 Sep 2022 17:27:10 -0700 [thread overview]
Message-ID: <xmqqbkra99gh.fsf@gitster.g> (raw)
In-Reply-To: <pull.1360.git.1663633195.gitgitgadget@gmail.com> (Victoria Dye via GitGitGadget's message of "Tue, 20 Sep 2022 00:19:53 +0000")
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> While locally verifying an unrelated documentation change, I noticed that
> the 'check-docs' target displayed two warnings on the 'master' branch:
>
> no link: git-diagnose
> removed but documented: git-version
>
>
> The first message was due to the introduction of 'git diagnose' [1] not
> including a corresponding update to 'command-list.txt'; the latter was due
> to 'git-version' not being built as a standalone builtin executable. This
> series corrects both, adding 'git-diagnose' and 'git-version' as
> "ancilliaryinterrogators" to 'command-list.txt' and building a 'git-version'
> executable.
Very much appreciated. I agree that making it an error would have
helped us a lot, and I also agree with you that it can be left for
the next cycle.
Will queue. Thanks.
prev parent reply other threads:[~2022-09-20 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 0:19 [PATCH 0/2] check-docs: fix 'diagnose' and 'version' Victoria Dye via GitGitGadget
2022-09-20 0:19 ` [PATCH 1/2] diagnose: add to command-list.txt Victoria Dye via GitGitGadget
2022-09-20 0:19 ` [PATCH 2/2] version: fix builtin linking & documentation Victoria Dye via GitGitGadget
2022-09-20 0:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkra99gh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).