git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: William Sprent via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Victoria Dye <vdye@github.com>,
	William Sprent <williams@unity3d.com>
Subject: Re: [PATCH 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag
Date: Thu, 09 Mar 2023 14:19:26 -0800	[thread overview]
Message-ID: <xmqqbkl18t5d.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGCgD+9s788YYmzvFHah0kik5QxbYPvWWf6mG--Pd5KPw@mail.gmail.com> (Elijah Newren's message of "Thu, 9 Mar 2023 07:31:37 -0800")

Elijah Newren <newren@gmail.com> writes:

> I'm of the opinion that having sparse-checkout-related functionality
> all fall under the 'sparse-checkout' command makes sense.  In the
> past, all such subcommands happened to require a working tree, but
> William has come up with a reasonable one that doesn't.  So, I'd be in
> favor of this mixing.

Yup, I am OK with that reasoning myself.

> I'll try to get a chance to review these patches soon, perhaps this weekend.

Thanks.

  reply	other threads:[~2023-03-09 22:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 13:49 [PATCH 0/2] builtin/sparse-checkout: add check-rules command William Sprent via GitGitGadget
2023-03-08 13:49 ` [PATCH 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag William Sprent via GitGitGadget
2023-03-08 18:14   ` Junio C Hamano
2023-03-08 19:27     ` Junio C Hamano
2023-03-09 15:31       ` Elijah Newren
2023-03-09 22:19         ` Junio C Hamano [this message]
2023-03-08 13:49 ` [PATCH 2/2] builtin/sparse-checkout: add check-rules command William Sprent via GitGitGadget
2023-03-19  4:26   ` Elijah Newren
2023-03-20 15:49     ` William Sprent
2023-03-19  4:28 ` [PATCH 0/2] " Elijah Newren
2023-03-27  7:55 ` [PATCH v2 " William Sprent via GitGitGadget
2023-03-27  7:55   ` [PATCH v2 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag William Sprent via GitGitGadget
2023-03-27 17:51     ` Junio C Hamano
2023-04-07 16:16       ` SZEDER Gábor
2023-04-07 16:38         ` Junio C Hamano
2023-03-27  7:55   ` [PATCH v2 2/2] builtin/sparse-checkout: add check-rules command William Sprent via GitGitGadget
2023-04-01 18:49   ` [PATCH v2 0/2] " Elijah Newren
2023-04-03 17:07     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbkl18t5d.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    --cc=vdye@github.com \
    --cc=williams@unity3d.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).