From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B602E1F44D for ; Wed, 24 Apr 2024 14:54:30 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=vc9tCCXb; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7908928C6EB for ; Wed, 24 Apr 2024 14:54:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39E5015F3FD; Wed, 24 Apr 2024 14:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="vc9tCCXb" Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83D715EFA1 for ; Wed, 24 Apr 2024 14:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.228.157.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713970413; cv=none; b=huokrJB79H1M3JeIFj+j4gvjEXsQvSzj3BkGxP9fyPJVtmByoFIZKjRRYQcwOdr7QsddczjoFelA9ONARPqvmVw4Y7tGkMgDL/GByAAq1KM6E9Q9vRhWwrHxA5mTaJ/JaIevbSkdnwdBbbpiN25UHZzqwkGlEKPyXmyKpaakuSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713970413; c=relaxed/simple; bh=Lg4axU+01Igs85afFtkMlgFgKULf/emPeGDyrRwa4XU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cBt+TGiu+htXwMyChOBtanydfh4NNUC3LqSUQnXvcuzL/FMZOGr6gJ7Y1DxDFCmyx1L1bLP2nGUjpaBcKbXsdVgawoZg7etwIfTCPNtvEE1rHsphIRk8Sfau2KUysXJaAsBot9kXFh4LkEXyScO3UrrZ/X1Cz1k+/NAI7cLaRz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=vc9tCCXb; arc=none smtp.client-ip=173.228.157.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id D097D33E8D; Wed, 24 Apr 2024 10:53:31 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=Lg4axU+01Igs85afFtkMlgFgKULf/emPeGDyrR wa4XU=; b=vc9tCCXbUbTTXfoqCMdQS6j+9v+Igl9u3wSZhB6Z6ltQ5wv4LsDOGY hacHpui8lN4IafiIqId7q6iKdERFxJQ7JQQKZvsgXAiMXQGOg5zjpMn/nkBQtANs 1irnyihxOgpJc4CoyvJbWqlkkuHq/W6bMkSTM/O01xIhkFFpDaLMM= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id C84C733E8C; Wed, 24 Apr 2024 10:53:31 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.120.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id ABEEC33E8B; Wed, 24 Apr 2024 10:53:27 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Patrick Steinhardt Cc: Teng Long , git@vger.kernel.org Subject: Re: [PATCH v2 7/7] builtin/reflog: introduce subcommand to list reflogs In-Reply-To: (Patrick Steinhardt's message of "Wed, 24 Apr 2024 10:01:55 +0200") References: <20240424073047.53755-1-tenglong.tl@alibaba-inc.com> Date: Wed, 24 Apr 2024 07:53:25 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 68945D0E-024A-11EF-A5EA-A19503B9AAD1-77302942!pb-smtp21.pobox.com Patrick Steinhardt writes: > On Wed, Apr 24, 2024 at 03:30:47PM +0800, Teng Long wrote: >> Patrick Steinhardt wrote: >> >> +#define BUILTIN_REFLOG_LIST_USAGE \ >> + N_("git reflog list") >> >> Doesn't seem to need a translation here? > > I was following the precedent of the other subcommands, which all mark > their usage as needing translation. Whether that is ultimately warranted > I can't really tell. In any case, if we decide that it's not we should > also drop the marker for all the other usages. The motivation for N_() in others (namely, the ones with s) is that the literal part like "git" "reflog" "expire" and "--expire=" cannot be given differently even when the user works in a different locale, but placeholders that explain the meaning of what the user must plug in there like "