* [PATCH] Document the --no-gui option in difftool
@ 2017-02-06 3:41 Denton Liu
2017-02-06 18:53 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Denton Liu @ 2017-02-06 3:41 UTC (permalink / raw)
To: git; +Cc: davvid
Prior to this, the `--no-gui` option was not documented in the manpage.
This commit introduces this into the manpage
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
Documentation/git-difftool.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-difftool.txt b/Documentation/git-difftool.txt
index 224fb3090..a2661d9cc 100644
--- a/Documentation/git-difftool.txt
+++ b/Documentation/git-difftool.txt
@@ -87,9 +87,11 @@ instead. `--no-symlinks` is the default on Windows.
-g::
--gui::
+--no-gui::
When 'git-difftool' is invoked with the `-g` or `--gui` option
the default diff tool will be read from the configured
- `diff.guitool` variable instead of `diff.tool`.
+ `diff.guitool` variable instead of `diff.tool`. The `--no-gui`
+ option can be used to override this setting.
--[no-]trust-exit-code::
'git-difftool' invokes a diff tool individually on each file.
--
2.12.0.rc0.208.g81c5d00b2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Document the --no-gui option in difftool
2017-02-06 3:41 [PATCH] Document the --no-gui option in difftool Denton Liu
@ 2017-02-06 18:53 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2017-02-06 18:53 UTC (permalink / raw)
To: Denton Liu; +Cc: git, davvid
Denton Liu <liu.denton@gmail.com> writes:
> diff --git a/Documentation/git-difftool.txt b/Documentation/git-difftool.txt
> index 224fb3090..a2661d9cc 100644
> --- a/Documentation/git-difftool.txt
> +++ b/Documentation/git-difftool.txt
> @@ -87,9 +87,11 @@ instead. `--no-symlinks` is the default on Windows.
>
> -g::
> --gui::
> +--no-gui::
> When 'git-difftool' is invoked with the `-g` or `--gui` option
> the default diff tool will be read from the configured
> - `diff.guitool` variable instead of `diff.tool`.
> + `diff.guitool` variable instead of `diff.tool`. The `--no-gui`
> + option can be used to override this setting.
>
> --[no-]trust-exit-code::
> 'git-difftool' invokes a diff tool individually on each file.
Reading the whole of this file before applying this patch, I notice
that we have descriptions of negative forms only for some but not
all options. "--[no-]symlinks" and "--[no-]trust-exit-code" are
already there, but not this one.
Shouldn't the patch be more like
---gui::
+--[no-]gui::
to be consistent with its existing friends, though?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-06 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 3:41 [PATCH] Document the --no-gui option in difftool Denton Liu
2017-02-06 18:53 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).