From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D416E20958 for ; Mon, 27 Mar 2017 00:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdC0A25 (ORCPT ); Sun, 26 Mar 2017 20:28:57 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:61918 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751609AbdC0A24 (ORCPT ); Sun, 26 Mar 2017 20:28:56 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B46B56EE59; Sun, 26 Mar 2017 20:27:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=lYzldIfYoyQA sMFbkz5wqNf6xkY=; b=tqokRiFHKz/g0CFPBHL3xSkrnxb2OwekIwjtOP8Ivlvp NBFnNtzfsszCX7XLQIzlFi8s27B+RIK+VE+n5YFFcZkl7L9lHQDz/leKiwgYhoxK aA+0JxUwMT5xkciHx3+xH1Boj/Qq6hPFWou6B80uJhIGmP+20KLNyRNjW8dzScw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=it12gh rckkEbHQUNlp/FBz2viYtVrj/Hy2YNCO0AOZGMwkMZ6QCs3z5nbGsud3DA4lw1sQ FoTLob0UZ4xlsnkUhXzLE1zEcP/OFFcE3nWNM8d4mCHR8J7UHSHZNRiZ3wi33Mm7 ESauW9CAazwHTWVA/acKH8CpDQ39jPscLITNs= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id AB0A86EE58; Sun, 26 Mar 2017 20:27:32 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 035A56EE57; Sun, 26 Mar 2017 20:27:32 -0400 (EDT) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Conrad Irwin , Sitaram Chamarty , Michael J Gruber , Nguyen Thai Ngoc Duy , Jeff King , "Brian M . Carlson" Subject: Re: [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively References: <20170326121654.22035-1-avarab@gmail.com> <20170326121654.22035-2-avarab@gmail.com> Date: Sun, 26 Mar 2017 17:27:30 -0700 In-Reply-To: <20170326121654.22035-2-avarab@gmail.com> (=?utf-8?B?IsOGdmFy?= =?utf-8?B?IEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sun, 26 Mar 2017 12:16:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 2AC9F9A6-1284-11E7-A787-97B1B46B9B0B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > The ^{} suffix could be changed to be case-insensitive as well > without introducing any ambiguities. That was included in an earlier > version of this patch, but Junio objected to its inclusion in [2]. We try not to be personal in our log message. It's not like my objection weighs heavier than objections from others. The same number of bytes in the log message can better to spent to allow readers of "git log" independently to judge the rationle without referring to external material. Perhaps replace this entire paragraph, including the URL in [2], with something like The ^{type} suffix is not made case-insensitive, because other places that take like "cat-file -t " do want them case sensitively (after all we never declared that type names are case insensitive). Allowing case-insensitive typename only with this syntax will make the resulting Git as a whole inconsistent. Other than that, the change to the code and the new tests all makes sense to me. Thanks.