mailing list mirror (one of many)
 help / Atom feed
From: Junio C Hamano <>
To: Ævar Arnfjörð Bjarmason <>
Cc:, Conrad Irwin <>, Sitaram Chamarty <>, Michael J Gruber <>, Nguyen Thai Ngoc Duy <>, Jeff King <>, "Brian M . Carlson" <>
Subject: Re: [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively
Date: Sun, 26 Mar 2017 17:27:30 -0700
Message-ID: <> (raw)
In-Reply-To: <>

Ævar Arnfjörð Bjarmason  <> writes:

> The ^{<type>} suffix could be changed to be case-insensitive as well
> without introducing any ambiguities. That was included in an earlier
> version of this patch, but Junio objected to its inclusion in [2].

We try not to be personal in our log message.  It's not like my
objection weighs heavier than objections from others.  The same
number of bytes in the log message can better to spent to allow
readers of "git log" independently to judge the rationle without
referring to external material.

Perhaps replace this entire paragraph, including the URL in [2],
with something like

    The ^{type} suffix is not made case-insensitive, because other
    places that take <type> like "cat-file -t <type>" do want them
    case sensitively (after all we never declared that type names
    are case insensitive). Allowing case-insensitive typename only
    with this syntax will make the resulting Git as a whole

Other than that, the change to the code and the new tests all makes
sense to me.


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-26 12:16 [PATCH v2 0/3] rev-parse case insensitivity & @{p} synonym Ævar Arnfjörð Bjarmason
2017-03-19 22:53 ` [PATCH] rev-parse: match @{u}, @{push} and ^{<type>} case-insensitively Junio C Hamano
2017-03-26 12:16   ` [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively Ævar Arnfjörð Bjarmason
2017-03-27  0:27     ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox