From: Junio C Hamano <gitster@pobox.com>
To: second.payre@gmail.com
Cc: git@vger.kernel.org,
PAYRE NATHAN p1508475 <nathan.payre@etu.univ-lyon1.fr>,
MOY Matthieu <matthieu.moy@univ-lyon1.fr>,
Daniel Bensoussan <daniel.bensoussan--bohm@etu.univ-lyon1.fr>,
Timothee Albertin <timothee.albertin@etu.univ-lyon1.fr>
Subject: Re: [PATCH v2] Documentation/git-config.txt: reword missleading sentence
Date: Fri, 13 Oct 2017 09:23:20 +0900 [thread overview]
Message-ID: <xmqqa80vyjyf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171012091727.30759-1-second.payre@gmail.com> (second payre's message of "Thu, 12 Oct 2017 11:17:27 +0200")
second.payre@gmail.com writes:
> From: PAYRE NATHAN p1508475 <nathan.payre@etu.univ-lyon1.fr>
Should I assume that the name/address on the last Signed-off-by: we
see below is what you want to be known as? As a part of school
work, I'd imagine that Matthieu wants your work to be associated
with the univ-lyon1.fr address, so perhaps you want to go the other
way around? It's not my place to decide between the two, but it is
unusual to see that the name/address of the author (which is the
above line) does not match what is on the Signed-off-by: line.
> Change the word "bla" to "section.variable", "bla" is a placeholder
> for a variable name and it wasn't clear for everyone.
> This change clarify it.
>
> Change the appearance of 'git config section.variable {tilde}/' to
> `git config section.variable {tilde}/` to harmonize it with
> the rest of the file, this is a command line then the "`" are
> necessary.
>
> Replace "git-config" by "git config" because the command
> is not "git-config".
>
> See discussion at:
> https://public-inbox.org/git/20171002061303.Horde.SL92grZCqTRV9oQkBFPELQ7@crashcourse.ca/
>
> Signed-off-by: MOY Matthieu <matthieu.moy@univ-lyon1.fr>
> Signed-off-by: Daniel Bensoussan <daniel.bensoussan--bohm@etu.univ-lyon1.fr>
> Signed-off-by: Timothee Albertin <timothee.albertin@etu.univ-lyon1.fr>
> Signed-off-by: Nathan Payre <second.payre@gmail.com>
> Noticed-by: rpjday@crashcourse.ca
> ---
> Documentation/git-config.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt
> index 83f86b923..2ab9e4c56 100644
> --- a/Documentation/git-config.txt
> +++ b/Documentation/git-config.txt
> @@ -174,11 +174,11 @@ See also <<FILES>>.
> either --bool or --int, as described above.
>
> --path::
> - 'git-config' will expand leading '{tilde}' to the value of
> + 'git config' will expand leading '{tilde}' to the value of
> '$HOME', and '{tilde}user' to the home directory for the
> specified user. This option has no effect when setting the
> - value (but you can use 'git config bla {tilde}/' from the
> - command line to let your shell do the expansion).
> + value (but you can use `git config section.variable {tilde}/`
Does this reference to {tilde} get expanded inside the `literal`
mark-up? In the description for 'gitdir', we find this passage (in
Documentation/config.txt):
* If the pattern starts with `~/`, `~` will be substituted with the
content of the environment variable `HOME`.
So I'd expect `~` to be a safe way to get what you want, not `{tilde}`.
> + from the command line to let your shell do the expansion).
>
> -z::
> --null::
next prev parent reply other threads:[~2017-10-13 0:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 8:17 [PATCH] Documentation/git-config.txt: reword missleading sentence PAYRE NATHAN p1508475
2017-10-05 10:13 ` Junio C Hamano
2017-10-10 8:19 ` Nathan PAYRE
2017-10-10 8:48 ` Junio C Hamano
2017-10-12 9:17 ` [PATCH v2] " second.payre
2017-10-13 0:23 ` Junio C Hamano [this message]
2017-10-13 8:32 ` Moy Matthieu
2017-10-13 12:04 ` Junio C Hamano
2017-10-18 20:27 ` [PATCH v3] " PAYRE NATHAN p1508475
2017-10-18 22:12 ` Jonathan Nieder
2017-10-19 4:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa80vyjyf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=daniel.bensoussan--bohm@etu.univ-lyon1.fr \
--cc=git@vger.kernel.org \
--cc=matthieu.moy@univ-lyon1.fr \
--cc=nathan.payre@etu.univ-lyon1.fr \
--cc=second.payre@gmail.com \
--cc=timothee.albertin@etu.univ-lyon1.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).