From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Kaartic Sivaraam" <kaartic.sivaraam@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [RFC PATCH] builtin/worktree: enhance worktree removal
Date: Wed, 22 Nov 2017 11:12:21 +0900 [thread overview]
Message-ID: <xmqqa7zfxdru.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAPig+cQrC1MiPrwwPqtdX2tzj1ntFHxO28uqnMBcmVpPPrc_Rg@mail.gmail.com> (Eric Sunshine's message of "Tue, 21 Nov 2017 16:37:58 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> Let me see if I understand. Sometimes you know that you've deleted the
> worktree directory, in which case 'git worktree prune' is the obvious
> choice. However, there may be cases when you've forgotten that you
> deleted the worktree directory (or it got deleted some other way), yet
> it still shows up in "git worktree list" output with no indication
> that it has been deleted (though, ideally, it should tell you so[1]).
> In this case, you see a worktree that you know you no longer want, so
> you invoke "git worktree remove" but that errors out because the
> actual directory is already gone. This patch make the operation
> succeed, despite the missing directory. Is that correct?
Hmph, so the user could be using "git worktree prune" after seeing
the error? Was there a reason behind "git worktree remove" to be
extra careful to make sure both existed before going forward, or was
this a simple oversight?
next prev parent reply other threads:[~2017-11-22 2:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 15:09 [RFC PATCH] builtin/worktree: enhance worktree removal Kaartic Sivaraam
2017-11-21 21:37 ` Eric Sunshine
2017-11-22 2:12 ` Junio C Hamano [this message]
2017-11-22 3:14 ` Eric Sunshine
2017-11-22 3:23 ` Eric Sunshine
2017-11-22 3:55 ` Junio C Hamano
2017-11-22 4:37 ` Eric Sunshine
2017-11-22 17:51 ` Kaartic Sivaraam
2017-11-27 17:36 ` [RFC PATCH v2] " Kaartic Sivaraam
2017-11-28 3:02 ` Junio C Hamano
2017-11-28 3:48 ` Eric Sunshine
2017-11-28 4:04 ` Junio C Hamano
2017-11-28 6:02 ` Eric Sunshine
2017-11-28 16:46 ` Kaartic Sivaraam
2017-11-22 17:13 ` [RFC PATCH] " Kaartic Sivaraam
2017-11-22 17:09 ` Kaartic Sivaraam
2017-11-22 18:05 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7zfxdru.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).