From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Clemens Buchacher <drizzd@gmx.net>,
git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Orgad Shaneh <orgads@gmail.com>
Subject: Re: [PATCH v2] checkout files in-place
Date: Mon, 11 Jun 2018 15:46:45 -0700 [thread overview]
Message-ID: <xmqqa7s1aqlm.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87a7s1vw9a.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 11 Jun 2018 23:38:57 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> ...And this seems to conflict with what Junio's summarized in
> xmqqvaapb3r1.fsf@gitster-ct.c.googlers.com. I.e. (if I'm reading it
> correctly) it's not correct to say that we unlink the existing file,
> then replace it, don't we create a new one, and then rename it in-place?
No, my recollection was incorrect. entry.c::checkout_entry() does
an unlink() then write_entry() to the final place without any
rename-to-finish phase.
prev parent reply other threads:[~2018-06-11 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 19:44 [PATCH] checkout files in-place Clemens Buchacher
2018-06-11 2:04 ` brian m. carlson
2018-06-11 17:48 ` Clemens Buchacher
2018-06-11 18:02 ` Junio C Hamano
2018-06-11 20:22 ` Clemens Buchacher
2018-06-11 17:59 ` Ævar Arnfjörð Bjarmason
2018-06-11 20:35 ` Edward Thomson
2018-06-11 20:57 ` Clemens Buchacher
[not found] ` <CAGHpTBJFwToEwnk4P17AJ+z-55Nzc04OBbTvsbFRrkXJpfXAkQ@mail.gmail.com>
2018-06-12 8:51 ` Edward Thomson
2018-06-13 7:39 ` Orgad Shaneh
2018-06-11 20:39 ` [PATCH v2] " Clemens Buchacher
2018-06-11 21:38 ` Ævar Arnfjörð Bjarmason
2018-06-11 22:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7s1aqlm.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=drizzd@gmx.net \
--cc=git@vger.kernel.org \
--cc=orgads@gmail.com \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).