From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Han-Wen Nienhuys <hanwen@google.com>,
sunshine@sunshineco.com, git@vger.kernel.org
Subject: Re: Re* [PATCH v7 1/1] sideband: highlight keywords in remote sideband output
Date: Mon, 20 Aug 2018 07:21:54 -0700 [thread overview]
Message-ID: <xmqqa7phce4d.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180818232220.GA24533@sigill.intra.peff.net> (Jeff King's message of "Sat, 18 Aug 2018 19:22:21 -0400")
Jeff King <peff@peff.net> writes:
>> In the longer term we may want to accept size_t as parameter for
>> clarity (even though we know that a sideband message we are painting
>> typically would fit on a line on a terminal and int is sufficient).
>> Write it down as a NEEDSWORK comment.
>
> This "typically" made me nervous about what happens in the non-typical
> case, but I think we can say something even stronger: the length comes
> from a pktline, so the maximum is less than 16 bits. I wondered if we
> might ever call this on the accumulated string from multiple sidebands,
> but it doesn't look like it.
I think a sideband packet may be split on one but not the other
codepath to result in multiple calls, but I do not think we coalesce
them together, so I agree that int is sufficient.
next prev parent reply other threads:[~2018-08-20 14:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 12:51 [PATCH v7 0/1] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-07 12:51 ` [PATCH v7 1/1] " Han-Wen Nienhuys
2018-08-17 18:33 ` Junio C Hamano
2018-08-17 18:44 ` Re* " Junio C Hamano
2018-08-18 6:09 ` Jonathan Nieder
2018-08-18 14:40 ` Junio C Hamano
2018-08-18 16:02 ` Junio C Hamano
2018-08-18 16:16 ` Junio C Hamano
2018-08-18 23:22 ` Jeff King
2018-08-20 14:21 ` Junio C Hamano [this message]
2018-08-20 12:21 ` Han-Wen Nienhuys
2018-08-20 12:21 ` Han-Wen Nienhuys
2018-08-20 14:32 ` Junio C Hamano
2018-08-18 6:35 ` Jonathan Nieder
2018-08-18 16:06 ` Junio C Hamano
2018-08-07 21:01 ` [PATCH v7 0/1] " Junio C Hamano
2018-08-08 13:12 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7phce4d.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanwen@google.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).