From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, Stas Bekman <stas@stason.org>,
git@vger.kernel.org
Subject: Re: git silently ignores include directive with single quotes
Date: Mon, 10 Sep 2018 11:30:31 -0700 [thread overview]
Message-ID: <xmqqa7optdbs.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180910171422.GA26356@aiede.svl.corp.google.com> (Jonathan Nieder's message of "Mon, 10 Sep 2018 10:14:22 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> 1. Treat single-quote as worth quoting in config.c::write_pair (line
> 2516). This would already help with the original issue, since the
> config would say
>
> [foo]
> bar = \'baz\'
>
> allowing a quick diagnosis.
I am mildly against this, as long as you feel that all the remaining
steps need to be marked with "(optional)", because this will give
readers an impression that somehow single-quote is special. If we
do not intend to make it special at all, we shouldn't.
If we do commit to make it special, then this is a very sensible
first step that is backward compatible, of course, and I find that
the following steps form a reasonable transition plan, if we intend
to follow all the way through.
> 2. (optional) Warn if a value is surrounded in single-quotes,
> encouraging using backslash to disambiguate.
>
> 3. (optional) Error out if a value is surrounded in single-quotes,
> encouraging using double-quote or backslash, depending on the
> user's intention.
>
> 4. (optional) Start treating wrapping single-quotes specially
> somehow.
>
> I think step 1 is a good idea, but I'm not convinced about any of the
> later steps.
>
> I also agree with the comments upthread about wanting a way to do a
> '[include] path' that errors out if the file doesn't exist, and maybe
> even starting a transition to repurpose standard [include] path to do
> that.
next prev parent reply other threads:[~2018-09-10 18:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 18:58 git silently ignores include directive with single quotes Stas Bekman
2018-09-08 19:30 ` Martin Ågren
2018-09-08 19:44 ` Stas Bekman
2018-09-08 19:53 ` Stas Bekman
2018-09-08 20:02 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:13 ` Stas Bekman
2018-09-08 20:28 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:58 ` Stas Bekman
2018-09-09 2:51 ` Paul Smith
2018-09-09 2:57 ` Stas Bekman
2018-09-08 19:54 ` Ævar Arnfjörð Bjarmason
2018-09-08 20:04 ` Stas Bekman
2018-09-08 20:16 ` Ævar Arnfjörð Bjarmason
2018-09-08 21:14 ` Jeff King
2018-09-08 22:10 ` Ramsay Jones
2018-09-09 2:33 ` Jeff King
2018-09-11 20:36 ` Junio C Hamano
2018-09-11 20:57 ` Jeff King
2018-09-23 22:48 ` Stas Bekman
2018-09-24 21:08 ` Ævar Arnfjörð Bjarmason
2018-09-24 23:20 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 0/1] " Philip Oakley
2018-09-24 23:05 ` Stas Bekman
2018-09-24 22:24 ` [PATCH 1/1] config doc: highlight the name=value syntax Philip Oakley
2018-09-25 22:03 ` Junio C Hamano
2018-09-08 22:32 ` git silently ignores include directive with single quotes Ævar Arnfjörð Bjarmason
2018-09-09 2:29 ` Jeff King
2018-09-08 21:22 ` Jeff King
2018-09-08 22:49 ` Stas Bekman
2018-09-09 2:30 ` Jeff King
2018-09-10 17:04 ` Junio C Hamano
2018-09-10 17:14 ` Jonathan Nieder
2018-09-10 18:30 ` Junio C Hamano [this message]
2018-09-10 18:35 ` Jonathan Nieder
2018-09-10 19:17 ` Junio C Hamano
2018-09-10 19:52 ` Stas Bekman
2018-09-10 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7optdbs.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=stas@stason.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).