From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] fetch-object: provide only one fetching function
Date: Thu, 13 Sep 2018 13:55:51 -0700 [thread overview]
Message-ID: <xmqqa7olf76w.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180913180932.93341-1-jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 13 Sep 2018 11:09:32 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
>> Instead of explaining why the new convention is better to justify
>> (2), the above three lines handwave by saying "more flexible"
>> twice. We should do better.
>>
>> fetch-object: unify fetch_object[s] functions
>>
>> There are fetch_object() and fetch_objects() helpers in
>> fetch-object.h; as the latter takes "struct oid_array",
>> the former cannot be made into a thin wrapper around the
>> latter without an extra allocation and set-up cost.
>>
>> Update fetch_objects() to take an array of "struct
>> object_id" and number of elements in it as separate
>> parameters, remove fetch_object(), and adjust all existing
>> callers of these functions to use the new fetch_objects().
>>
>> perhaps?
>
> Thanks - your explanation is much clearer than mine. Let me know if you
> want a reroll (or if you can update the commit message yourself, that's
> fine too).
If there is no other change needed for either of the patches, I do
not mind rewording the 1/2 myself to save a round-trip.
Thanks.
next prev parent reply other threads:[~2018-09-13 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:47 [PATCH 0/2] Bugfix for partial clones and ref-in-want servers Jonathan Tan
2018-09-12 15:47 ` [PATCH 1/2] fetch-object: provide only one fetching function Jonathan Tan
2018-09-12 21:50 ` Junio C Hamano
2018-09-13 18:09 ` Jonathan Tan
2018-09-13 20:55 ` Junio C Hamano [this message]
2018-09-12 15:47 ` [PATCH 2/2] fetch-object: set exact_oid when fetching Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa7olf76w.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).