From: Junio C Hamano <gitster@pobox.com>
To: Alban Gruin <alban.gruin@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
git@vger.kernel.org, "Elijah Newren" <newren@gmail.com>,
"Ævar Arnfjörð" <avarab@gmail.com>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Jeff King" <peff@peff.net>,
"Eugeniu Rosca" <roscaeugeniu@gmail.com>
Subject: Re: [PATCH v1] rebase -i: stop checking out the tip of the branch to rebase
Date: Wed, 22 Jan 2020 12:24:06 -0800 [thread overview]
Message-ID: <xmqqa76f6xzt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200121191857.23047-1-alban.gruin@gmail.com> (Alban Gruin's message of "Tue, 21 Jan 2020 20:18:57 +0100")
Alban Gruin <alban.gruin@gmail.com> writes:
> This introduces a visible change: as we do not switch on the tip of the
> branch to rebase, no reflog entry is created at the beginning of the
> rebase for it.
Fortunately, this does not mean "git log @{-1}.." during a rebase
starts to behave differently. If it were the case, that would have
been a bad regression, but that is not the case.
If you omit one reflog entry, you are creating TWO changes. The
detaching of the HEAD to the "onto" commit would record, just like
any other reflog entry, would record from which commit we detached
HEAD from. That reflog entry will also be different, as you'd be
switching from a different commit.
I am not sure what the implication of this difference will be in
practice, though, but it must be smaller than the effect of the
missing reflog entry discussed earlier.
next prev parent reply other threads:[~2020-01-22 20:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 21:43 Unreliable 'git rebase --onto' Eugeniu Rosca
2020-01-08 22:35 ` SZEDER Gábor
2020-01-09 0:55 ` Elijah Newren
2020-01-09 15:03 ` SZEDER Gábor
2020-01-09 17:53 ` Elijah Newren
2020-01-21 19:18 ` [PATCH v1] rebase -i: stop checking out the tip of the branch to rebase Alban Gruin
2020-01-21 20:07 ` Elijah Newren
2020-01-22 20:24 ` Junio C Hamano [this message]
2020-01-22 20:47 ` Junio C Hamano
2020-01-24 14:45 ` Alban Gruin
2020-01-24 14:45 ` [PATCH v2] " Alban Gruin
2020-01-24 14:55 ` Alban Gruin
2020-01-24 18:12 ` Junio C Hamano
2020-01-24 15:05 ` [PATCH v3] " Alban Gruin
2020-01-24 18:30 ` Junio C Hamano
2020-02-05 14:31 ` Johannes Schindelin
2020-01-24 17:11 ` [PATCH v2] " Andrei Rybak
2020-01-09 11:13 ` Unreliable 'git rebase --onto' Eugeniu Rosca
[not found] ` <CABPp-BHsyMOz+hi7EYoAnAWfzms7FRfwqCoarnu8H+vyDoN6SQ@mail.gmail.com>
2020-01-09 10:53 ` Eugeniu Rosca
2020-01-09 18:05 ` Elijah Newren
2020-01-10 0:06 ` Eugeniu Rosca
2020-01-10 2:35 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa76f6xzt.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=alban.gruin@gmail.com \
--cc=avarab@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=roscaeugeniu@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).