From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 985B01F619 for ; Tue, 3 Mar 2020 18:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730252AbgCCStu (ORCPT ); Tue, 3 Mar 2020 13:49:50 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:53746 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729203AbgCCStu (ORCPT ); Tue, 3 Mar 2020 13:49:50 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6243AC62BF; Tue, 3 Mar 2020 13:49:48 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=2Xz/JuphP6PKcewc9nIHgIEi6rQ=; b=sZe2By ut687wIyNQBMVQAc2bpUTGE9fdMWxeKW56czdJgpSp6Y7iHLXzZBM+teZjfOAkNk 3IlgRjU3zN9p+kTHiDKQNR9EDjkjh+LXisNitDoCd3+Bx8WSDMG8J4CX3tNCUm4r WKjpm1mEkR8Tsk9rPDQsUPvvAWWLMHFCQqxG8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=hVRKosIJuMFKKw2WPeaEyQA9oBUBE5l6 szsPBzwXWOtavW+F9+ly32b4bDasTNesVrsezd6HvTiXTU4yJMApsFCvEWvwwxVj Sa69ydLbXifThiLRsN6jASKVGUltgPvLkbDc/4RYCtIy0HWISNYgjlRwMtbkTuBr f+Fvq0G4pK8= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5A59CC62BE; Tue, 3 Mar 2020 13:49:48 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 8759EC62BD; Tue, 3 Mar 2020 13:49:45 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Damien Robert Cc: git@vger.kernel.org Subject: Re: [PATCH 1/2] doc: update the documentation of pack-objects and repack References: <20200228154357.1710521-1-damien.olivier.robert+git@gmail.com> <20200228154357.1710521-2-damien.olivier.robert+git@gmail.com> <20200303174136.ess5lfxrsrt6qvdu@feanor> Date: Tue, 03 Mar 2020 10:49:43 -0800 In-Reply-To: <20200303174136.ess5lfxrsrt6qvdu@feanor> (Damien Robert's message of "Tue, 3 Mar 2020 18:41:36 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C03D3CE8-5D7F-11EA-9A5A-B0405B776F7B-77302942!pb-smtp20.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Damien Robert writes: > The problem here is that > `--keep-true-parents`, `--no-empty`, `--all`, `--reflog`, `--indexed-objects`, > `--exclude-promisor-objects` > are always passed and not driven by any options of `git repack`, so I > did not know where else to put them. Ah, I think I may have misread the patch, then. Why do readers who wanted to learn 'git repack' even need to see what the command does under the hood, driving what other low-level commands by passing what options, in the first place? Such implementation details can change without affecting end-users, no?