git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Elijah Newren <newren@gmail.com>, git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.26.0-rc1
Date: Tue, 10 Mar 2020 13:58:12 -0700	[thread overview]
Message-ID: <xmqqa74ohqqj.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200310174017.GA549010@coredump.intra.peff.net> (Jeff King's message of "Tue, 10 Mar 2020 13:40:17 -0400")

Jeff King <peff@peff.net> writes:

> The first change is that we'll now open an editor when continuing a
> conflicted rebase. You can see it by running this:
> ...
> We won't run the editor the "apply" backend, but do for "merge".  I'm
> not sure how big a deal this is.

Back when "git am" was written, it was not considered a bug that the
"git am --resolved" option did not offer the user a chance to update
the log message to match the adjustment of the code the user made,
but honestly, I'd have to say that it is a bug in "git am" in that
over time it wasn't adjusted to the new world order where we
encourage users to describe what they did when the automation
hiccuped by opening an editor.  These days, even when automation
worked well (e.g. a clean auto-merge with "git merge"), we open an
editor.  The world has changed, and so should the expectations.

If it were that we used to let the users edit and the new behaviour
is to auto-continue, it would be a quite drastic behaviour change
that may annoy the users, but fortunately this is the other way
around, so it may not be too bad.  Having said all that, I do not
mind some workaround, e.g. "git rebase --continue --no-edit".

"GIT_EDITOR=: git rebase --continue" would be a usable workaround
that does not require any code change, hopefully.




  parent reply	other threads:[~2020-03-10 20:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 14:57 [ANNOUNCE] Git v2.26.0-rc1 Junio C Hamano
2020-03-10 17:40 ` Jeff King
2020-03-10 19:08   ` Junio C Hamano
2020-03-10 19:27     ` Elijah Newren
2020-03-10 19:48     ` Jeff King
2020-03-10 20:58   ` Junio C Hamano [this message]
2020-03-11 16:28     ` Jeff King
2020-03-11  5:25   ` Elijah Newren
2020-03-11 13:54 ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa74ohqqj.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).