From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A6A6A1F5AD for ; Fri, 10 Apr 2020 05:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725897AbgDJFjZ (ORCPT ); Fri, 10 Apr 2020 01:39:25 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:55430 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbgDJFjZ (ORCPT ); Fri, 10 Apr 2020 01:39:25 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 6CD0743C94; Fri, 10 Apr 2020 01:39:25 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=6NDAVyVTZQYjM5CKHQExnFyW5q8=; b=ozlmWK zu/BJCCXwAvPcYAV3EeTli6G8DmvPBThYtQxu+xy9gTaiVFkuT6G/d2EfCLYcmZo X30qKio39jlIZQ6UdE1K53xup6zDCsdSUnTWEAnbpsaFvWa5gqf6OE1612SpEwwO 0m5tf3HuYrbfrQSxK+0xjnpMlKld09HAKmK7E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=L8l0mNDw067BjmTiIFZH9lzzG6MG4Gpj XS0IMgqO2C5maEEfXEZ1ZsdulHxsmHFlAehW3BrI4kZH0yZ8ZimW9CsAKoc9NEmj hEpI7W84oB+tjavoIzeEWsg6o7QerDJuTxELqy3y1ldC26PM+OFKSUT4u9LfoxF7 jlrHc5AeE2A= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 631E243C93; Fri, 10 Apr 2020 01:39:25 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id E251343C86; Fri, 10 Apr 2020 01:39:24 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: =?utf-8?Q?=C3=89rico?= Rolim , git@vger.kernel.org Subject: Re: Re* [BUG] segmentation fault in git-diff References: <20200409234152.GA42330@coredump.intra.peff.net> <20200410030411.GA48173@coredump.intra.peff.net> Date: Thu, 09 Apr 2020 22:39:24 -0700 In-Reply-To: <20200410030411.GA48173@coredump.intra.peff.net> (Jeff King's message of "Thu, 9 Apr 2020 23:04:11 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A30A37E4-7AED-11EA-A55E-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > I prepared the patch below on top. I mostly wanted it as an auditing > tool to find similar cases, but there were none. It may still be worth > applying to protect ourselves in the future. Makes perfect sense. Will queue. Thanks.