From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 64D691F55B for ; Mon, 8 Jun 2020 22:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbgFHWKv (ORCPT ); Mon, 8 Jun 2020 18:10:51 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:50385 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbgFHWKv (ORCPT ); Mon, 8 Jun 2020 18:10:51 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id EF221C9778; Mon, 8 Jun 2020 18:10:48 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=kbclEE4Hwz1avcZ+q/mZ+ci76uA=; b=PIba9a C0dWTZA9lQbDyWjyzWYriVl8VDKkpCbp0Wfrf3lFZKtjost14Kk8IaRXORH6OAH9 sPbS9E2LRxL/IiUA7zR07/zz5JLvZEwf6uIYlVStdZY9yMPa8BcmVEo1xoOjaOPm qBCf/IMl0zLPhtVyDVzhfKc8XD6NXJPJTWGjc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=DU6m4sIYd7Gr7K2oBQSBFqbovyq8lu9s EsK/E3SMp/kDYIvY3d8AKu/motZ3WfvhgU9Hml8JQG8FOGGxaRZneIFy73jVHz/J RSW+5ToNDRw8cV5n/pQU/joCl0MTLzscrOvVs2oaYM5MWopkjm9/B58DpO8eLtIH 8SBwO/p7ce4= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id E7CADC9777; Mon, 8 Jun 2020 18:10:48 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 39143C976B; Mon, 8 Jun 2020 18:10:46 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Sibi Siddharthan Cc: Sibi Siddharthan via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH v3 2/8] cmake: generate the shell/perl/python scripts and templates, translations References: Date: Mon, 08 Jun 2020 15:10:44 -0700 In-Reply-To: (Sibi Siddharthan's message of "Tue, 9 Jun 2020 01:37:56 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: E708E7A4-A9D4-11EA-8F2F-8D86F504CC47-77302942!pb-smtp21.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Sibi Siddharthan writes: > Hi Junio, > > I have done the suggested changes namely: > 1) Format code inside check_c_source_compiles/runs > 2) Moved the changelog of the patch series from the commit messages to > the cover letter > 3) parse for SCRIPT_LIB > 4) glob templates and po files > 5) add logic as to where the template file should be built. > > Any other changes I should do before I a new version of the patch series? > > Thank You, > Sibi Siddharthan Sorry, but I read too many patch series that I do not remember glitches I pointed out in the previous round of individual topics. So asking that question is waste of both of our times. Just use the time necessary to compose that message to instead proofread one more time, scan the review thread of previous round and make sure you took everybody's input into consideration (you do not have to follow everything other people said---you just need to be able to solidly stand behind the decision you made to follow or not follow them in your latest version). Thanks.