From: Junio C Hamano <gitster@pobox.com>
To: Tobias Girstmair <tobi@isticktoit.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] gitweb: Replace <base> tag with full URLs (when using PATH_INFO)
Date: Sun, 12 Jul 2020 21:34:36 -0700 [thread overview]
Message-ID: <xmqqa704owwz.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200712230508.GA1000433@isticktoit.net> (Tobias Girstmair's message of "Mon, 13 Jul 2020 01:05:08 +0200")
Tobias Girstmair <tobi@isticktoit.net> writes:
> On Sun, Jul 12, 2020 at 02:00:01PM -0700, Junio C Hamano wrote:
>>Sorry, but I am not sure the description is understandable to the
>>intended readers of this sentence.
>>
>>Where does this README.html come from?
>
> gitweb reads a README.html from each repository to display on the
> summary page. 'man 1 gitweb' has a paragraph on it under
> "Per-repository gitweb configuration".
>
>>Is it stored in the history of the repository as a blob, and sent to
>>the browser with a call to git_blob_plain() sub? Wouldn't that
>
> No, it's a plain file in a bare repository, placed there either
> manually or by a post-update hook.
OK.
> ... If the user wanted to
> include an image, they'd write <img src="blob_plain/HEAD:/image.png">
> (assuming this patch landed).
And without this patch, the src URL needs to know where this
repository appears in the site's URL namespace?
If that is the case, the change makes quite a lot of sense.
Thanks.
next prev parent reply other threads:[~2020-07-13 4:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 20:39 [PATCH] gitweb: Replace <base> tag with full URLs (when using PATH_INFO) Tobias Girstmair
2020-07-12 18:24 ` [PATCH v2] " Tobias Girstmair
2020-07-12 18:33 ` [PATCH v3] " Tobias Girstmair
2020-07-12 21:00 ` Junio C Hamano
2020-07-12 23:05 ` Tobias Girstmair
2020-07-13 4:34 ` Junio C Hamano [this message]
2020-07-13 9:29 ` Tobias Girstmair
2020-07-13 14:44 ` Junio C Hamano
2020-07-13 14:59 ` Tobias Girstmair
2020-11-20 15:19 ` Tobias Girstmair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa704owwz.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tobi@isticktoit.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).