From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Matheus Tavares <matheus.bernardino@usp.br>
Subject: Re: [PATCH v3] builtin/clone: avoid failure with GIT_DEFAULT_HASH
Date: Tue, 22 Sep 2020 09:27:21 -0700 [thread overview]
Message-ID: <xmqqa6xhlqty.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200922091717.GP67496@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 22 Sep 2020 09:17:17 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2020-09-21 at 04:27:14, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>> > +test_expect_success 'clone with GIT_DEFAULT_HASH' '
>> > + (
>> > + sane_unset GIT_DEFAULT_HASH &&
>> > + git init --object-format=sha1 test-sha1 &&
>> > + git init --object-format=sha256 test-sha256
>> > + ) &&
>> > + test_commit -C test-sha1 foo &&
>> > + test_commit -C test-sha256 foo &&
>>
>> Unfortunately, the 'foo' commit is created in test-sha1, but the
>> next step to create 'foo' in test-sha256 fails with
>>
>> fatal: unknown repository extensions found:
>> objectformat
>
> I'm not seeing that with this series based on master
> (385c171a018f2747b329bcfa6be8eda1709e5abd). I'm doing this:
>
> make -j6 all && (cd t && GIT_TEST_DEFAULT_HASH=sha256 ./t5601-*.sh --verbose)
> make -j6 all && (cd t && GIT_TEST_DEFAULT_HASH=sha1 ./t5601-*.sh --verbose)
>
> And getting this output:
>
> Initialized empty Git repository in /home/bmc/checkouts/git/t/trash directory.t5601-clone/test-sha1/.git/
> Initialized empty Git repository in /home/bmc/checkouts/git/t/trash directory.t5601-clone/test-sha256/.git/
> [master (root-commit) 946e985] foo
> Author: A U Thor <author@example.com>
> 1 file changed, 1 insertion(+)
> create mode 100644 foo.t
> [master (root-commit) ff872d8] foo
> Author: A U Thor <author@example.com>
> 1 file changed, 1 insertion(+)
> create mode 100644 foo.t
> Cloning into 'test-clone-sha256'...
> done.
> Cloning into 'test-clone-sha1'...
> done.
> On branch master
> Your branch is up to date with 'origin/master'.
>
> nothing to commit, working tree clean
> On branch master
> Your branch is up to date with 'origin/master'.
>
> nothing to commit, working tree clean
>
> Is there something I'm missing here?
I think the issue was because I queued the patch on the same base as
the previous round, which was v2.28.0. Whe applied to 385c171a
(Fifteenth batch, 2020-09-18), I get the same as the above.
Sorry about the noise. Will queue again.
prev parent reply other threads:[~2020-09-22 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:17 Posible bug with GIT_DEFAULT_HASH during clone Matheus Tavares
2020-09-11 23:20 ` brian m. carlson
2020-09-11 23:38 ` [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH brian m. carlson
2020-09-12 3:24 ` Taylor Blau
2020-09-12 19:52 ` brian m. carlson
2020-09-14 21:37 ` Junio C Hamano
2020-09-14 21:44 ` Junio C Hamano
2020-09-15 1:32 ` brian m. carlson
2020-09-15 1:58 ` [PATCH v2] " brian m. carlson
2020-09-15 4:31 ` Junio C Hamano
2020-09-15 22:51 ` brian m. carlson
2020-09-20 22:35 ` [PATCH v3] " brian m. carlson
2020-09-21 4:27 ` Junio C Hamano
2020-09-22 9:17 ` brian m. carlson
2020-09-22 16:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6xhlqty.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).