git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] SQUASH??? calloc(nmemb,size)
@ 2021-03-11 18:02 Junio C Hamano
  2021-03-15 10:24 ` Han-Wen Nienhuys
  0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2021-03-11 18:02 UTC (permalink / raw)
  To: Han-Wen Nienhuys; +Cc: git

Please squash this in to an appropriate step in your series;
otherwise it triggers a Coccinelle check when merged to 'seen'.

Thanks.

 refs/reftable-backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
index b7d12ca91d..6faad8ce50 100644
--- a/refs/reftable-backend.c
+++ b/refs/reftable-backend.c
@@ -996,7 +996,7 @@ static struct ref_iterator_vtable git_reftable_reflog_ref_iterator_vtable = {
 static struct ref_iterator *
 git_reftable_reflog_iterator_begin(struct ref_store *ref_store)
 {
-	struct git_reftable_reflog_ref_iterator *ri = xcalloc(sizeof(*ri), 1);
+	struct git_reftable_reflog_ref_iterator *ri = xcalloc(1, sizeof(*ri));
 	struct git_reftable_ref_store *refs =
 		(struct git_reftable_ref_store *)ref_store;
 
-- 
2.31.0-rc2-173-g36b77366ca


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] SQUASH??? calloc(nmemb,size)
  2021-03-11 18:02 [PATCH] SQUASH??? calloc(nmemb,size) Junio C Hamano
@ 2021-03-15 10:24 ` Han-Wen Nienhuys
  0 siblings, 0 replies; 2+ messages in thread
From: Han-Wen Nienhuys @ 2021-03-15 10:24 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Thu, Mar 11, 2021 at 7:02 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Please squash this in to an appropriate step in your series;
> otherwise it triggers a Coccinelle check when merged to 'seen'.
>

folded in, thanks.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-15 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 18:02 [PATCH] SQUASH??? calloc(nmemb,size) Junio C Hamano
2021-03-15 10:24 ` Han-Wen Nienhuys

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).