From: Junio C Hamano <firstname.lastname@example.org> To: Phillip Wood <email@example.com> Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, Elijah Newren <firstname.lastname@example.org>, Elijah Newren via GitGitGadget <email@example.com>, Git Mailing List <firstname.lastname@example.org>, Philip Oakley <email@example.com> Subject: Re: unifying sequencer's options persisting, was Re: [PATCH v2] sequencer: fix edit handling for cherry-pick and revert messages Date: Fri, 02 Apr 2021 14:01:17 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Phillip Wood's message of "Fri, 2 Apr 2021 12:28:43 +0100") Phillip Wood <firstname.lastname@example.org> writes: > I think we would save a lot by only syncing the state to disk when we > stop or run an exec command (the state needs to be synced so exec > commands can alter the todo list). In those cases we need to write the > index and possibly run an external process so writing a couple of > files is probably insignificant. The optimization opportunity of this may be a lot smaller than you would think---you must cater to not just exec but hook scripts that are run while a new commit is made, which means every step you'd need to write anyway. > Where I think we can usefully consolidate is the one-line files which > store the options rather than state - these are read an written much > less frequently so I don't think they have much of a performance hit > but it would be much nicer to just serialize the options to a single > file. Would that break external scripts, hooks, etc.? I am not sure if we even have any rough consensus for allowing other people to peek into the .git/rebase-*/ directories, but I am inclined to say that it sounds more like a solution looking for a problem than a good idea to solve some concrete problem.
next prev parent reply other threads:[~2021-04-02 21:01 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-26 7:16 [PATCH] " Elijah Newren via GitGitGadget 2021-03-26 12:27 ` Philip Oakley 2021-03-26 15:12 ` Elijah Newren 2021-03-28 1:30 ` Junio C Hamano 2021-03-29 9:23 ` Phillip Wood 2021-03-29 20:52 ` Junio C Hamano 2021-03-29 21:25 ` Elijah Newren 2021-03-30 2:09 ` [PATCH v2] " Elijah Newren via GitGitGadget 2021-03-30 10:13 ` Johannes Schindelin 2021-03-30 18:47 ` Junio C Hamano 2021-03-30 20:16 ` Elijah Newren 2021-03-31 17:36 ` Ævar Arnfjörð Bjarmason 2021-03-31 17:52 ` Elijah Newren 2021-03-31 18:01 ` Junio C Hamano 2021-04-01 16:31 ` Elijah Newren 2021-03-30 19:37 ` Elijah Newren 2021-03-31 13:48 ` unifying sequencer's options persisting, was " Johannes Schindelin 2021-04-02 11:28 ` Phillip Wood 2021-04-02 13:10 ` Phillip Wood 2021-04-02 21:01 ` Junio C Hamano [this message] 2021-04-02 22:18 ` Elijah Newren 2021-04-02 22:27 ` Junio C Hamano 2021-04-08 2:40 ` Johannes Schindelin 2021-04-08 17:45 ` Junio C Hamano 2021-04-08 19:58 ` Christian Couder 2021-04-09 13:53 ` Johannes Schindelin 2021-03-31 6:52 ` [PATCH v3] " Elijah Newren via GitGitGadget 2021-03-31 14:38 ` Johannes Schindelin 2021-04-02 11:40 unifying sequencer's options persisting, was Re: [PATCH v2] " Gabriel Young
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: unifying sequencer'\''s options persisting, was Re: [PATCH v2] sequencer: fix edit handling for cherry-pick and revert messages' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).