From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
git@vger.kernel.org
Subject: Re: There should have be git gc --repack-arguments
Date: Wed, 07 Apr 2021 15:13:39 -0700 [thread overview]
Message-ID: <xmqqa6q9yc8c.fsf@gitster.g> (raw)
In-Reply-To: <YG4mImcQyTC1/S8X@coredump.intra.peff.net> (Jeff King's message of "Wed, 7 Apr 2021 17:37:38 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Apr 07, 2021 at 01:40:16PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> >> ... git repack ... --max-pack-size=<desired pack size> to create split and
>> >> smaller packs instead.
>> > ...
>> > You can also set pack.packSizeLimit for the latter, though I do not
>> > recommend it. It will not help with memory usage (neither while
>> > repacking nor for later commands).
>>
>> In other words, passing --max-pack-size, whether it is done with a
>> new --repack-arguments option or it is done with the existing
>> pack.packSizeLimit configuration, would make things worse.
>
> Right. I wish we didn't have --max-pack-size at all. I do not think it
> is ever a good idea, and it complicates the packing code quite a bit.
I suspect that the original motivation was sneaker-netting on
multiple floppy disks ;-)
>> - on a small box, it may make sense to avoid repacking everything
>> into one in the first place, but we do not want the number of
>> packs to grow unbounded.
>>
>> Would the new geometric repack feature help here, especially for the
>> latter?
>
> Yes, I think it would. You'd perhaps want to generate a multi-pack-index
> file, too, to avoid having to look for objects in multiple packs
> sequentially (we have a "git repack --write-midx" option on the way, as
> well).
Thanks.
next prev parent reply other threads:[~2021-04-07 22:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:10 There should have be git gc --repack-arguments Bagas Sanjaya
2021-04-07 19:37 ` Jeff King
2021-04-07 20:40 ` Junio C Hamano
2021-04-07 21:37 ` Jeff King
2021-04-07 22:13 ` Junio C Hamano [this message]
2021-04-07 22:22 ` Jeff King
2021-04-09 9:58 ` Bagas Sanjaya
2021-04-09 15:49 ` Jeff King
2021-04-07 19:38 ` Bryan Turner
2021-04-08 13:31 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6q9yc8c.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).