From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F35991F8C6 for ; Wed, 1 Sep 2021 23:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242877AbhIAXKu (ORCPT ); Wed, 1 Sep 2021 19:10:50 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56355 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242052AbhIAXKt (ORCPT ); Wed, 1 Sep 2021 19:10:49 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id DB19514B15B; Wed, 1 Sep 2021 19:09:51 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=3xKNNZv7TyNwd9a6YJ4KVRQ0JR3rS1las2Tle9xclBc=; b=sIAr w0TRbxNmnZOur+uxQlLpg11evJ3Pp6Gvan8vnuF2R5fzDPF74cbEy7A9ypb75/0a AJIQpzVzxgceWDUrtz5ta10x9IpH7e8plKrneBdz0o11iH7hTnCIb3jYG4rPFc4j RUmQZLdq4zGxwEbgbiXLhL91mnfrthh3Wkf1UtI= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id C68B814B159; Wed, 1 Sep 2021 19:09:51 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.116.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id F179C14B157; Wed, 1 Sep 2021 19:09:47 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Elijah Newren Cc: Philippe Blain via GitGitGadget , Git Mailing List , SZEDER =?utf-8?Q?G=C3=A1bor?= , Johannes Schindelin , Jens Lehmann , Eric Sunshine , Taylor Blau , Carlo Arenas , Jeff King , Philippe Blain Subject: Re: [PATCH v3 2/3] test-lib-functions: optionally keep HOME, TERM and SHELL in 'test_pause' References: <328b5d6e76f598590d24b35ec23b5fd854c6cf05.1630503102.git.gitgitgadget@gmail.com> Date: Wed, 01 Sep 2021 16:09:46 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B3F9C006-0B79-11EC-AD09-FA11AF6C5138-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Elijah Newren writes: >> Because a new process instance of $PAUSE_SHELL is run, the options >> you add when inserting test_pause does not affect what happens in >> the tests after you exit the $PAUSE_SHELL [*], right? > > I think the warning was less about what happens after test_pause is > complete and the testcase resumes, and more intended to convey that if > the user tries to manually copy & paste snippets of code from the test > into $PAUSE_SHELL, then the use of these flags can cause the result of > those pasted commands to differ. But the difference of TERM and SHELL are much smaller issue when one cuts and pastes the lines from the test script. Even if you do not use -s or -t options, shell variables and helpers won't be available to the interactive session given by test_pause, and that is a much bigger difference between the "real" shell environment that is running the tests and the user's shell environment test_pause gives us. That is why I think the WARNING should be attached _directly_ to the description of test_pause and not to individual "this uses different X environment compared to the real shell environment running the tests" options. The updated $HOME does deserve a special mention, as .gitconfig from it would further affect the tests and hide the bug you are hunting for, and the CAUTION is a good thing to have, even if you do not plan to modify anything in the test_pause sight-seeing session.