From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jeff King <peff@peff.net>,
Andriy Makukha via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Andriy Makukha <andriy.makukha@gmail.com>
Subject: Re: [PATCH] strlcpy(): safer and faster version
Date: Fri, 17 Dec 2021 14:42:05 -0800 [thread overview]
Message-ID: <xmqqa6gy3lc2.fsf@gitster.g> (raw)
In-Reply-To: <211217.86sfur9503.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 17 Dec 2021 06:22:30 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> Thanks for saying everything I wanted to say ;-)
>
> Isn't strlcpy() an OpenBSD-initiated effort? So if we're going to update
Yes.
> this at all shouldn't be be aiming for picking an "upstream" here?
> E.g. [1]?
If this were an improvement, yes. But if I am reading the patch
correctly, it changes what the value returned from the function
means. I do not think that would fly even in the upstream, without
a very good justification. Adding a new function that has semantics
different from strlcpy() might be a possibility at upstream, but as
far as this project is concerned, if we were to change the use of
strlcpy() in the codebase, we often have tools that are much better
suited in our arsenal, as Peff already mentioned, so...
prev parent reply other threads:[~2021-12-17 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 17:31 [PATCH] strlcpy(): safer and faster version Andriy Makukha via GitGitGadget
2021-12-16 18:14 ` Jeff King
2021-12-16 22:32 ` Junio C Hamano
2021-12-17 5:22 ` Ævar Arnfjörð Bjarmason
2021-12-17 22:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa6gy3lc2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=andriy.makukha@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).